From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59935C433F5 for ; Wed, 13 Apr 2022 15:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E+RBfcBQ3rDZn75SkcUkzMJFFnMpAy7ZTsm1CAQITl4=; b=PfSFgOvh/dSKCb krP8S5pCUj7tEBnJ3svTZQIqntRUx2DjHDpqqBjn6jb7GTou3WEorflJi+BKbEnrpPwE/4KfCVYCw UXtNeaNtajE6+m6HRsHZblYYI4JhT5E3EUD+aafQQyR1y2EF9uszQx4lxkvWZOPDP7Np5oBHvVzmH 7ueBNDIfLhu3R2n1SMTFh2iKd37zX7w6MC47OeErdWstHm3pdccL7O0uss3TwjuhE4FsMC2hlINx+ 4790pzX619x2Z28zKPkQw6NYZkV75ABUUIsow/5FM+CyBn0DUOzZXxBrpI5rZLghsZNscdlNvLL94 J65Q3ew54Pg9k5SAJQsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neeWF-001WO8-4A; Wed, 13 Apr 2022 15:02:55 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neeWC-001WN9-2c for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 15:02:53 +0000 Received: from [192.168.254.32] (unknown [47.189.24.195]) by linux.microsoft.com (Postfix) with ESMTPSA id BFF6E20C34C9; Wed, 13 Apr 2022 08:02:50 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BFF6E20C34C9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1649862171; bh=hVcQEDWYVYIBhnwPWdpGqP50H0c6Y+2U49ZZaTTAmGI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oywVQNz1MQG5KAA2Jvj/el6q7HqvPXj2G/jpAXIP3QpJXcAjQu81mQYo6x6ygqLP2 J3w28vIgtKUeiP4yfewctivO4pAc/Y3DhoreFS+qnU5egJYxCKxnqUzA7Z2yvU/qla TpRMc+ZREkWrV1PY663FavuZJtoKt68OlDEiCiM4= Message-ID: Date: Wed, 13 Apr 2022 10:02:49 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/6] arm64: stacktrace: delete PCS comment Content-Language: en-US To: Mark Rutland , linux-arm-kernel@lists.infradead.org Cc: broonie@kernel.org, catalin.marinas@arm.com, kaleshsingh@google.com, will@kernel.org References: <20220413145910.3060139-1-mark.rutland@arm.com> <20220413145910.3060139-3-mark.rutland@arm.com> From: "Madhavan T. Venkataraman" In-Reply-To: <20220413145910.3060139-3-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220413_080252_174483_B7E3C72C X-CRM114-Status: GOOD ( 15.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/13/22 09:59, Mark Rutland wrote: > The comment at the top of stacktrace.c isn't all that helpful, as it's > not associated with the code which inspects the frame record, and the > code example isn't representative of common code generation today. > > Delete it. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: Madhavan T. Venkataraman > Cc: Mark Brown > Cc: Will Deacon > --- > arch/arm64/kernel/stacktrace.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c > index 94932ade5c79..08af9ca9a845 100644 > --- a/arch/arm64/kernel/stacktrace.c > +++ b/arch/arm64/kernel/stacktrace.c > @@ -18,21 +18,6 @@ > #include > #include > > -/* > - * AArch64 PCS assigns the frame pointer to x29. > - * > - * A simple function prologue looks like this: > - * sub sp, sp, #0x10 > - * stp x29, x30, [sp] > - * mov x29, sp > - * > - * A simple function epilogue looks like this: > - * mov sp, x29 > - * ldp x29, x30, [sp] > - * add sp, sp, #0x10 > - */ > - > - > static notrace void start_backtrace(struct stackframe *frame, unsigned long fp, > unsigned long pc) > { Reviewed-by: Madhavan T. Venkataraman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel