* [PATCH] arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie0
@ 2025-07-21 9:59 Guoqing Jiang
2025-07-21 12:13 ` AngeloGioacchino Del Regno
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Guoqing Jiang @ 2025-07-21 9:59 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, matthias.bgg, angelogioacchino.delregno,
jianjun.wang, tinghan.shen
Cc: macpaul.lin, guoqing.jiang, devicetree, linux-arm-kernel,
linux-mediatek
When test suspend resume with 6.8 based kernel, system can't resume
and I got below error which can be also reproduced with 6.16 rc6+
kernel.
mtk-pcie-gen3 112f0000.pcie: PCIe link down, current LTSSM state: detect.quiet (0x0)
mtk-pcie-gen3 112f0000.pcie: PM: dpm_run_callback(): genpd_resume_noirq returns -110
mtk-pcie-gen3 112f0000.pcie: PM: failed to resume noirq: error -110
After investigation, looks pcie0 has the same problem as pcie1 as
decribed in commit 3d7fdd8e38aa ("arm64: dts: mediatek: mt8195:
Remove suspend-breaking reset from pcie1").
Fixes: ecc0af6a3fe6 ("arm64: dts: mt8195: Add pcie and pcie phy nodes")
Signed-off-by: Guoqing Jiang <guoqing.jiang@canonical.com>
---
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index dd065b1bf94a..50cf01452208 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -1563,9 +1563,6 @@ pcie0: pcie@112f0000 {
power-domains = <&spm MT8195_POWER_DOMAIN_PCIE_MAC_P0>;
- resets = <&infracfg_ao MT8195_INFRA_RST2_PCIE_P0_SWRST>;
- reset-names = "mac";
-
#interrupt-cells = <1>;
interrupt-map-mask = <0 0 0 7>;
interrupt-map = <0 0 0 1 &pcie_intc0 0>,
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie0
2025-07-21 9:59 [PATCH] arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie0 Guoqing Jiang
@ 2025-07-21 12:13 ` AngeloGioacchino Del Regno
2025-07-24 5:40 ` Macpaul Lin (林智斌)
2025-07-24 5:56 ` Macpaul Lin (林智斌)
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-07-21 12:13 UTC (permalink / raw)
To: Guoqing Jiang, robh, krzk+dt, conor+dt, matthias.bgg,
jianjun.wang, tinghan.shen
Cc: macpaul.lin, devicetree, linux-arm-kernel, linux-mediatek
Il 21/07/25 11:59, Guoqing Jiang ha scritto:
> When test suspend resume with 6.8 based kernel, system can't resume
> and I got below error which can be also reproduced with 6.16 rc6+
> kernel.
>
> mtk-pcie-gen3 112f0000.pcie: PCIe link down, current LTSSM state: detect.quiet (0x0)
> mtk-pcie-gen3 112f0000.pcie: PM: dpm_run_callback(): genpd_resume_noirq returns -110
> mtk-pcie-gen3 112f0000.pcie: PM: failed to resume noirq: error -110
>
> After investigation, looks pcie0 has the same problem as pcie1 as
> decribed in commit 3d7fdd8e38aa ("arm64: dts: mediatek: mt8195:
> Remove suspend-breaking reset from pcie1").
>
> Fixes: ecc0af6a3fe6 ("arm64: dts: mt8195: Add pcie and pcie phy nodes")
> Signed-off-by: Guoqing Jiang <guoqing.jiang@canonical.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie0
2025-07-21 12:13 ` AngeloGioacchino Del Regno
@ 2025-07-24 5:40 ` Macpaul Lin (林智斌)
0 siblings, 0 replies; 6+ messages in thread
From: Macpaul Lin (林智斌) @ 2025-07-24 5:40 UTC (permalink / raw)
To: matthias.bgg@gmail.com, Jianjun Wang (王建军),
Guoqing Jiang, AngeloGioacchino Del Regno, robh@kernel.org,
TingHan Shen (沈廷翰), joying.guo@mediatek.com,
krzk+dt@kernel.org, Jieyy Yang (杨洁),
Chuanjia Liu (柳传嘉),
Jianguo Zhang (张建国), conor+dt@kernel.org,
Jingming Jiang (江经明)
Cc: linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Macpaul Lin (林智斌),
devicetree@vger.kernel.org, macpaul@gmail.com,
Ramax Lo (羅明遠)
On Mon, 2025-07-21 at 14:13 +0200, AngeloGioacchino Del Regno wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> Il 21/07/25 11:59, Guoqing Jiang ha scritto:
> > When test suspend resume with 6.8 based kernel, system can't resume
> > and I got below error which can be also reproduced with 6.16 rc6+
> > kernel.
> >
> > mtk-pcie-gen3 112f0000.pcie: PCIe link down, current LTSSM state:
> > detect.quiet (0x0)
> > mtk-pcie-gen3 112f0000.pcie: PM: dpm_run_callback():
> > genpd_resume_noirq returns -110
> > mtk-pcie-gen3 112f0000.pcie: PM: failed to resume noirq: error -110
> >
> > After investigation, looks pcie0 has the same problem as pcie1 as
> > decribed in commit 3d7fdd8e38aa ("arm64: dts: mediatek: mt8195:
> > Remove suspend-breaking reset from pcie1").
> >
> > Fixes: ecc0af6a3fe6 ("arm64: dts: mt8195: Add pcie and pcie phy
> > nodes")
> > Signed-off-by: Guoqing Jiang <guoqing.jiang@canonical.com>
>
> Reviewed-by: AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com>
>
>
Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com>
Dear Guoqing, please help to add Cc: stable@vger.kernel.org next time.
:)
Thanks
Macpaul Lin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie0
2025-07-21 9:59 [PATCH] arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie0 Guoqing Jiang
2025-07-21 12:13 ` AngeloGioacchino Del Regno
@ 2025-07-24 5:56 ` Macpaul Lin (林智斌)
2025-09-09 12:36 ` Matthias Brugger
2025-09-09 12:38 ` Matthias Brugger
3 siblings, 0 replies; 6+ messages in thread
From: Macpaul Lin (林智斌) @ 2025-07-24 5:56 UTC (permalink / raw)
To: matthias.bgg@gmail.com, Jianjun Wang (王建军),
Joying Kuo (郭羽喬), Guoqing Jiang,
Jingming Jiang (江经明), robh@kernel.org,
krzk+dt@kernel.org, TingHan Shen (沈廷翰),
Jieyy Yang (杨洁),
Chuanjia Liu (柳传嘉),
Jianguo Zhang (张建国), conor+dt@kernel.org,
AngeloGioacchino Del Regno
Cc: linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org
On Mon, 2025-07-21 at 17:59 +0800, Guoqing Jiang wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> When test suspend resume with 6.8 based kernel, system can't resume
> and I got below error which can be also reproduced with 6.16 rc6+
> kernel.
>
> mtk-pcie-gen3 112f0000.pcie: PCIe link down, current LTSSM state:
> detect.quiet (0x0)
> mtk-pcie-gen3 112f0000.pcie: PM: dpm_run_callback():
> genpd_resume_noirq returns -110
> mtk-pcie-gen3 112f0000.pcie: PM: failed to resume noirq: error -110
>
> After investigation, looks pcie0 has the same problem as pcie1 as
> decribed in commit 3d7fdd8e38aa ("arm64: dts: mediatek: mt8195:
> Remove suspend-breaking reset from pcie1").
>
> Fixes: ecc0af6a3fe6 ("arm64: dts: mt8195: Add pcie and pcie phy
> nodes")
> Signed-off-by: Guoqing Jiang <guoqing.jiang@canonical.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index dd065b1bf94a..50cf01452208 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1563,9 +1563,6 @@ pcie0: pcie@112f0000 {
>
> power-domains = <&spm
> MT8195_POWER_DOMAIN_PCIE_MAC_P0>;
>
> - resets = <&infracfg_ao
> MT8195_INFRA_RST2_PCIE_P0_SWRST>;
> - reset-names = "mac";
> -
> #interrupt-cells = <1>;
> interrupt-map-mask = <0 0 0 7>;
> interrupt-map = <0 0 0 1 &pcie_intc0 0>,
> --
> 2.34.1
>
Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com>
Please help to add Cc: stable@vger.kernel.org next time.
Thanks
Macpaul Lin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie0
2025-07-21 9:59 [PATCH] arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie0 Guoqing Jiang
2025-07-21 12:13 ` AngeloGioacchino Del Regno
2025-07-24 5:56 ` Macpaul Lin (林智斌)
@ 2025-09-09 12:36 ` Matthias Brugger
2025-09-09 12:38 ` Matthias Brugger
3 siblings, 0 replies; 6+ messages in thread
From: Matthias Brugger @ 2025-09-09 12:36 UTC (permalink / raw)
To: Guoqing Jiang, robh, krzk+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, jianjun.wang, tinghan.shen
Cc: macpaul.lin, devicetree, linux-arm-kernel, linux-mediatek
On 21/07/2025 11:59, Guoqing Jiang wrote:
> When test suspend resume with 6.8 based kernel, system can't resume
> and I got below error which can be also reproduced with 6.16 rc6+
> kernel.
>
> mtk-pcie-gen3 112f0000.pcie: PCIe link down, current LTSSM state: detect.quiet (0x0)
> mtk-pcie-gen3 112f0000.pcie: PM: dpm_run_callback(): genpd_resume_noirq returns -110
> mtk-pcie-gen3 112f0000.pcie: PM: failed to resume noirq: error -110
>
> After investigation, looks pcie0 has the same problem as pcie1 as
> decribed in commit 3d7fdd8e38aa ("arm64: dts: mediatek: mt8195:
> Remove suspend-breaking reset from pcie1").
>
> Fixes: ecc0af6a3fe6 ("arm64: dts: mt8195: Add pcie and pcie phy nodes")
> Signed-off-by: Guoqing Jiang <guoqing.jiang@canonical.com>
Queued, thanks!
Matthias
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index dd065b1bf94a..50cf01452208 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1563,9 +1563,6 @@ pcie0: pcie@112f0000 {
>
> power-domains = <&spm MT8195_POWER_DOMAIN_PCIE_MAC_P0>;
>
> - resets = <&infracfg_ao MT8195_INFRA_RST2_PCIE_P0_SWRST>;
> - reset-names = "mac";
> -
> #interrupt-cells = <1>;
> interrupt-map-mask = <0 0 0 7>;
> interrupt-map = <0 0 0 1 &pcie_intc0 0>,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie0
2025-07-21 9:59 [PATCH] arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie0 Guoqing Jiang
` (2 preceding siblings ...)
2025-09-09 12:36 ` Matthias Brugger
@ 2025-09-09 12:38 ` Matthias Brugger
3 siblings, 0 replies; 6+ messages in thread
From: Matthias Brugger @ 2025-09-09 12:38 UTC (permalink / raw)
To: Guoqing Jiang, robh, krzk+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, jianjun.wang, tinghan.shen
Cc: macpaul.lin, devicetree, linux-arm-kernel, linux-mediatek
On 21/07/2025 11:59, Guoqing Jiang wrote:
> When test suspend resume with 6.8 based kernel, system can't resume
> and I got below error which can be also reproduced with 6.16 rc6+
> kernel.
>
> mtk-pcie-gen3 112f0000.pcie: PCIe link down, current LTSSM state: detect.quiet (0x0)
> mtk-pcie-gen3 112f0000.pcie: PM: dpm_run_callback(): genpd_resume_noirq returns -110
> mtk-pcie-gen3 112f0000.pcie: PM: failed to resume noirq: error -110
>
> After investigation, looks pcie0 has the same problem as pcie1 as
> decribed in commit 3d7fdd8e38aa ("arm64: dts: mediatek: mt8195:
> Remove suspend-breaking reset from pcie1").
>
> Fixes: ecc0af6a3fe6 ("arm64: dts: mt8195: Add pcie and pcie phy nodes")
> Signed-off-by: Guoqing Jiang <guoqing.jiang@canonical.com>
Queued, thanks.
Matthias
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index dd065b1bf94a..50cf01452208 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1563,9 +1563,6 @@ pcie0: pcie@112f0000 {
>
> power-domains = <&spm MT8195_POWER_DOMAIN_PCIE_MAC_P0>;
>
> - resets = <&infracfg_ao MT8195_INFRA_RST2_PCIE_P0_SWRST>;
> - reset-names = "mac";
> -
> #interrupt-cells = <1>;
> interrupt-map-mask = <0 0 0 7>;
> interrupt-map = <0 0 0 1 &pcie_intc0 0>,
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-09-09 17:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-21 9:59 [PATCH] arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie0 Guoqing Jiang
2025-07-21 12:13 ` AngeloGioacchino Del Regno
2025-07-24 5:40 ` Macpaul Lin (林智斌)
2025-07-24 5:56 ` Macpaul Lin (林智斌)
2025-09-09 12:36 ` Matthias Brugger
2025-09-09 12:38 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox