From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A08B5C43458 for ; Mon, 13 Jul 2026 19:26:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: References:In-Reply-To:Date:To:From:Subject:Message-ID:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I5Xuiq8NQj6APix6vd4TJDu8T3rurGUlMnDaKp7R6vw=; b=EV3IImXooA3Rc2J+1LR6KISwuK AYkpRIcHxvGWchGZrdYhPBsyy/fC3fvXJkp2mcAFP+LXtUwO0lUXLoQA26zmwNDrF/3UrxoCEhOoe M31i62ZM4c0RRMHHHyqIkCfIzROGS+zdsFvyMEZnv1upIKXfwV6shHj3Ek6nRPvyukQGq46XOXELO WKeltQf0fJcNJixMpVojp+mj6WBLkrRbTBQhA4McgBfQmIk2BPd1aAXyXrZWaokU8T9lX1r8S+PsJ l4ouPg9WhGb5oIGAPojyoSLgEKpAtmY6CiBrUdedH8ZrVp2ihnGTqdIR97Pl0noIgRtwUwktYuscf h6V4tzTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjMIC-0000000AHke-1K0s; Mon, 13 Jul 2026 19:26:16 +0000 Received: from bali.collaboradmins.com ([2a01:4f8:201:9162::2]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjMIA-0000000AHjq-0pBs; Mon, 13 Jul 2026 19:26:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1783970770; bh=RcxFrzM4fXb6ommCnOiNc6tEa78VsTytrJHLMEScxm4=; h=Subject:From:To:Date:In-Reply-To:References:From; b=W/n0NHB7zpdXppS10/AVeJ2AI6xwRXLIm/akQboL82x9GxlSAgWWg4QuHRSrUVpLO 55kHkhTXFVYSz3DWH0C9G0TBVzJAFQJG186aMIT4VvGD3BnzjT8nI/xs/2wdlxlRc+ h5YWPQR7eFb0yZVn1Mn5LgO2tn/nK5dCMwMFblpzv8pRlMk3f9Mb/notJNEf4mITrn 0kpusqlXBqS1ZMcKzWDMPYuvCrUp8UCLbQMdsJ7F9xrEU7Xze7bhC67mMKjr55M+PU rry5Kt5BALb5nxiAyiarbcNb/5zcjwfn5JK1ewctu/8clOVJWphg5PV1FXl+auN8a5 IeMwVvUWDqWAQ== Received: from [100.64.0.214] (unknown [100.64.0.214]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by bali.collaboradmins.com (Postfix) with ESMTPSA id 48DF317E0956; Mon, 13 Jul 2026 21:26:08 +0200 (CEST) Message-ID: Subject: Re: [PATCH v15 02/12] media: mediatek: jpeg: fix jpeg buffer payload size setting From: Nicolas Dufresne To: Kyrie Wu , Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Date: Mon, 13 Jul 2026 15:26:05 -0400 In-Reply-To: <20260702072614.10373-3-kyrie.wu@mediatek.com> References: <20260702072614.10373-1-kyrie.wu@mediatek.com> <20260702072614.10373-3-kyrie.wu@mediatek.com> Autocrypt: addr=nicolas.dufresne@collabora.com; prefer-encrypt=mutual; keydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD /e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA cCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo CGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN abIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z nJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4 AWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ smBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC AAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF iEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw ECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8 bRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ Organization: Collabora Canada Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-3sVKmjtuPNin0J4FoPlf" User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260713_122614_392889_A1A17B49 X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --=-3sVKmjtuPNin0J4FoPlf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le jeudi 02 juillet 2026 =C3=A0 15:26 +0800, Kyrie Wu a =C3=A9crit=C2=A0: > For multi-core jpegdec, if one core gets resolution change event, > the payload size, representing the size of Y/C data, needs to change. > But others are decoding at the same time and it can not be changed > immediately, which results in the payload size to not match the real > buffer length. > The payload size must less than the real buffer length to remove must be less > the warnning logs. >=20 > Fixes: 0fa49df4222f ("media: mtk-jpegdec: support jpegdec multi-hardware"= ) > Signed-off-by: Kyrie Wu Reviewed-by: Nicolas Dufresne > --- > =C2=A0.../platform/mediatek/jpeg/mtk_jpeg_core.c=C2=A0=C2=A0=C2=A0 | 19 += +++++++++++++----- > =C2=A01 file changed, 14 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drive= rs/media/platform/mediatek/jpeg/mtk_jpeg_core.c > index 1e014fd698ae..3960ad21d7f0 100644 > --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c > @@ -702,6 +702,7 @@ static int mtk_jpeg_buf_prepare(struct vb2_buffer *vb= ) > =C2=A0 struct mtk_jpeg_ctx *ctx =3D vb2_get_drv_priv(vb->vb2_queue); > =C2=A0 struct mtk_jpeg_q_data *q_data =3D NULL; > =C2=A0 struct v4l2_plane_pix_format plane_fmt =3D {}; > + size_t max_size; > =C2=A0 int i; > =C2=A0 > =C2=A0 q_data =3D mtk_jpeg_get_q_data(ctx, vb->vb2_queue->type); > @@ -710,12 +711,20 @@ static int mtk_jpeg_buf_prepare(struct vb2_buffer *= vb) > =C2=A0 > =C2=A0 for (i =3D 0; i < q_data->fmt->colplanes; i++) { > =C2=A0 plane_fmt =3D q_data->pix_mp.plane_fmt[i]; > + max_size =3D plane_fmt.sizeimage; > + > =C2=A0 if (ctx->enable_exif && > - =C2=A0=C2=A0=C2=A0 q_data->fmt->fourcc =3D=3D V4L2_PIX_FMT_JPEG) > - vb2_set_plane_payload(vb, i, plane_fmt.sizeimage + > - =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MTK_JPEG_MAX_EXIF_SIZE); > - else > - vb2_set_plane_payload(vb, i,=C2=A0 plane_fmt.sizeimage); > + q_data->fmt->fourcc =3D=3D V4L2_PIX_FMT_JPEG) { > + max_size +=3D MTK_JPEG_MAX_EXIF_SIZE; > + > + vb2_set_plane_payload(vb, i, > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MIN(vb->planes[i].length, > + =C2=A0 max_size)); > + } else { > + vb2_set_plane_payload(vb, i, > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MIN(plane_fmt.sizeimage, > + =C2=A0 vb->planes[i].length)); > + } > =C2=A0 } > =C2=A0 > =C2=A0 return 0; --=-3sVKmjtuPNin0J4FoPlf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCalU7zQAKCRDZQZRRKWBy 9KLBAQC3VQew+lWIFYFAv9fg5BqMa9IRHChznBJwWMns6YzGrgD/WYdaWpblGdWI WFr3vCtL4w9cR0i7UPjjJ20jXFBktAQ= =dgdq -----END PGP SIGNATURE----- --=-3sVKmjtuPNin0J4FoPlf--