From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3019CCD199 for ; Mon, 20 Oct 2025 13:23:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=twNLkyeYrri2OQLBbsN6MguTa49g239UQ7T7I0pqboU=; b=RO/4KruPk/HItV3UHyP1Squ4D+ j0rmuh2z+wd1yvzcHvrrRWABbiHfX9FVY55XyndF5i4kHXkh9WWvAELwh1sNo1YKkCN5UaDPfdsQy 1SwSGzZsNuv2pVOG8Jiy/9vyMvjJ8IBpt/aVL6gNamZBWkUDqwePk0nWhKHh2KAepuOQpUnDFOcam VEGQao4LkQ3SMDBLSSL/m4r62NFaAfX3mq1zxIUS3keiJJYHe9RPYW2ssEqN3BuAo9E0QjSjFFgiV q8q+p1WgQoZN0ExnETymQbKM8uk8FOgyU3lTbJrX8baMXtrqn6AQNKAMpA+p05ccDJmradymGtwlf 3IRsrfLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vAprD-0000000Dm5J-08sn; Mon, 20 Oct 2025 13:23:27 +0000 Received: from canpmsgout04.his.huawei.com ([113.46.200.219]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vAprA-0000000Dm2V-1L3J for linux-arm-kernel@lists.infradead.org; Mon, 20 Oct 2025 13:23:25 +0000 dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=twNLkyeYrri2OQLBbsN6MguTa49g239UQ7T7I0pqboU=; b=q0esaEKRzsgQyVtjbId7vCmivLssOJarA7Lwm00G4h7svBRHJQI11IcqQ/LO6irUo79QoNVgc D30hKwakE6+ZLkMCOIqaf6x2ELJKOeeOZTZaG4whpCxgazv794kVWrHRWhOBNeEVop1OCNUx1+u AXcu4waFqByuNzzyhZSOl+A= Received: from mail.maildlp.com (unknown [172.19.88.105]) by canpmsgout04.his.huawei.com (SkyGuard) with ESMTPS id 4cqx1b39hyz1prLM; Mon, 20 Oct 2025 21:22:43 +0800 (CST) Received: from dggpemf500002.china.huawei.com (unknown [7.185.36.57]) by mail.maildlp.com (Postfix) with ESMTPS id 485761402DA; Mon, 20 Oct 2025 21:23:07 +0800 (CST) Received: from [10.174.178.247] (10.174.178.247) by dggpemf500002.china.huawei.com (7.185.36.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 20 Oct 2025 21:23:06 +0800 Subject: Re: [PATCH v4] ACPI: AGDI: Add interrupt signaling mode support To: Kazuhiro Abe , Lorenzo Pieralisi , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , , , CC: Ilkka Koskinen , Will Deacon , Catalin Marinas References: <20251017073935.1746365-1-fj1078ii@aa.jp.fujitsu.com> From: Hanjun Guo Message-ID: Date: Mon, 20 Oct 2025 21:23:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20251017073935.1746365-1-fj1078ii@aa.jp.fujitsu.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.247] X-ClientProxiedBy: kwepems100001.china.huawei.com (7.221.188.238) To dggpemf500002.china.huawei.com (7.185.36.57) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251020_062324_543413_729D9CE1 X-CRM114-Status: GOOD ( 10.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2025/10/17 15:39, Kazuhiro Abe wrote: > AGDI has two types of signaling modes: SDEI and interrupt. > Currently, the AGDI driver only supports SDEI. > Therefore, add support for interrupt signaling mode > The interrupt vector is retrieved from the AGDI table, and call panic > function when an interrupt occurs. > > Reviewed-by: Ilkka Koskinen > Signed-off-by: Kazuhiro Abe > --- > Hanjun, I have addressed all your comments. > Please review them. > > v3->v4 > - Add a comment to the flags member. > - Fix agdi_interrupt_probe. > - Fix agdi_interrupt_remove. > - Add space in struct initializsation. > - Delete curly braces. Looks good to me, Acked-by: Hanjun Guo Thanks Hanjun