From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB3EC433DB for ; Sat, 13 Mar 2021 20:24:32 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BABDF64DF3 for ; Sat, 13 Mar 2021 20:24:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BABDF64DF3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=somainline.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iLnucKFk9QuqlVAYykEStYBXTVNMLXZ+MBlHaIShLnw=; b=Ajxu5i232hg4Z0xZ58hzxXeMs tWGaG7Sjkm6I0htNS6p05kadCG1rLlqeem7JqihR5SmM6S2yhnEhZjG4XE2G+2pk0tIp8SELH1pF6 6hWUlC9laEzL8fLV9fgu7fS3xanXnyDB4yeMhUrDoR8ysJC2MlRbcs1zJQVj3VdG7WIzZX2FbrVLf tDE+5U3l+ib9l173uNVmgNTam6Hkhg9DJy5hBdMxyPK8HIGnzHhpPD6+YF7V4A5UAiAf31B+PQrZn YNZB61zlvVQYDIldzWnMt0TdzjrPDnUYvlzdg4qClC5QfUeXRb8pl3Zlanb+HfG6tV9MBQ/Qsjz0J zi9oM5AdQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLAmk-00DZAb-CN; Sat, 13 Mar 2021 20:22:54 +0000 Received: from relay08.th.seeweb.it ([5.144.164.169]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLAmg-00DZA3-Gh for linux-arm-kernel@lists.infradead.org; Sat, 13 Mar 2021 20:22:52 +0000 Received: from [192.168.1.101] (abac242.neoplus.adsl.tpnet.pl [83.6.166.242]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 024D13E927 for ; Sat, 13 Mar 2021 21:22:45 +0100 (CET) Subject: Re: [RFT PATCH v3 27/27] arm64: apple: Add initial Apple Mac mini (M1, 2020) devicetree To: linux-arm-kernel@lists.infradead.org References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-28-marcan@marcan.st> From: Konrad Dybcio Message-ID: Date: Sat, 13 Mar 2021 21:22:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210304213902.83903-28-marcan@marcan.st> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210313_202250_689607_7021D351 X-CRM114-Status: GOOD ( 17.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! > +++ b/arch/arm64/boot/dts/apple/t8103-j274.dts > @@ -0,0 +1,45 @@ > +// SPDX-License-Identifier: GPL-2.0+ OR MIT It seems to be "// SPDX-License-Identifier: (GPL-2.0+ OR MIT)" in other DTs (notice the brackets). > +/* > + * Apple Mac mini (M1, 2020) Not sure if it's necessary, you already state it in model="" > + * > + * target-type: J174 Isn't that a typo? Compatible states J*2*74, but I'm curious if that's intentional. > + * > + * Copyright The Asahi Linux Contributors * Copyright (C) 2021 The Asahi Linux Contributors > + */ > + > +/dts-v1/; > + > +#include "t8103.dtsi" > + > +/ { > + compatible = "apple,j274", "apple,t8103", "apple,arm-platform"; > + model = "Apple Mac mini (M1, 2020)"; > + > + aliases { > + serial0 = &serial0; Isn't this M1-common? > + }; > + > + chosen { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + stdout-path = "serial0"; Doesn't serial work without this? > + > + framebuffer0: framebuffer@0 { Not sure if we want the @0 (unless it's also overwritten by the loader). > + compatible = "apple,simple-framebuffer", "simple-framebuffer"; > + reg = <0 0 0 0>; /* To be filled by loader */ > + /* Format properties will be added by loader */ > + status = "disabled"; Does it get enabled by the loader? Also, isn't the framebuffer common for all M1 devices? > + }; > + }; > + > + memory@800000000 { > + device_type = "memory"; > + reg = <0x8 0 0x2 0>; /* To be filled by loader */ > + }; Shouldn't this be in the SoC DTSI? > +}; > + > +&serial0 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi > new file mode 100644 > index 000000000000..aac9e4e6abc5 > --- /dev/null > +++ b/arch/arm64/boot/dts/apple/t8103.dtsi > @@ -0,0 +1,135 @@ > +// SPDX-License-Identifier: GPL-2.0+ OR MIT > +/* > + * Apple T8103 "M1" SoC > + * > + * Other names: H13G, "Tonga" > + * > + * Copyright The Asahi Linux Contributors Ditto > + */ > + > +#include > +#include > + > +/ { > + compatible = "apple,t8103", "apple,arm-platform"; Please remove this line, it's getting overwritten anyway. > + }; > + > + soc { > + compatible = "simple-bus"; > + #address-cells = <2>; > + #size-cells = <2>; > + > + ranges; > + nonposted-mmio; > + I think " compatible = "simple-bus"; #address-cells = <2>; #size-cells = <2>; nonposted-mmio; ranges; " would look more coherent to the human eye, but that's rather a nit. Other than this, node order seems to be entirely random. Please sort them by address (where applicable) and by name where not, so that this doesn't become a huge mess as we go forward. Konrad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel