From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 761C7C4CECC for ; Mon, 27 Apr 2020 18:29:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9D0620728 for ; Mon, 27 Apr 2020 18:29:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tOVCLxGQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S4nPK50g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9D0620728 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JaOcZmu/5AlhUJdNR/05YC0GvAyZGYHB1NLWSQaicRg=; b=tOVCLxGQ7Sht6E iPq11SnEmE5fNBIh4752rHyg4DERplBHVUq5PXhk8ruRSRdhhmFj8ay967Mg8L5zwMrlu97gEqvum uVpH63bHAf0yX4fjDG6CmS/IVv3s0i/de7sCoYd3FyTOcKVQcnTtJVYxL+sDVssIcf75Ss6UbvbI5 FM2ZeYn1D57T4ES0iCEK9lMFJW930HLB6fOhZ5Wg4VBdH6XVc3XkkTjsqzp4Vkj6p0xgr2DSkHE1y D+n0A30HNRs9nJ1afJNnAnUMgbUmPk1p6MlDhfGP2d6+DNC0LxaMp+dTQy1mWdlCSKvJnx9QemRSd uPcMjSSStQYLyNT1eryA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT8V5-0001Mg-Sm; Mon, 27 Apr 2020 18:29:03 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT8V3-0001ML-8E for linux-arm-kernel@lists.infradead.org; Mon, 27 Apr 2020 18:29:02 +0000 Received: by mail-wr1-x443.google.com with SMTP id i10so21707240wrv.10 for ; Mon, 27 Apr 2020 11:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lHULapMa+BsXwsb7nFo4ngDpGWEQISNj1XIuagyOGJ4=; b=S4nPK50ggycLkdpsKEzm16DXDnDpUPNe4JP8XftG9GTRTK+xfH2TGDQFSNwNPozCih ROG2tV4mOoET9zFZxgHyO8sZNds7kijCfa1t80FBbbrnzf5+SAqv4Jt8nqIDrnLVYNTY Ok/bi2D18ftntyliblJnslVzyRoZiOTSOIEJEtu1swPu89TXasrNA4Bo54kfxwLl4PuT 8Xjla6GUzeZxhXOChhfv+56LKNUsfAFdDCapz8x6jkmhoM63hZh++Kbr/RHtxDI8f2zb AQBq4JWVdYep6lykSzc1EsNTVLj3nGaYPMIuhOcbsGEf0fsNWcpCYCBxgYlpUjBCMBf/ yXqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lHULapMa+BsXwsb7nFo4ngDpGWEQISNj1XIuagyOGJ4=; b=aV5OiL8ShO8xguxnry0GUQTP1FaT1DOJxFVWXwEcadPjPC0evZFhNc16dEdpuRkt8G Geg1tShevEv4C6noUnZNsOVlHrs02gjXOQhD+9FRYqpFwjdrKq6WhZpDjVlCaVnMgzra rR9poV91Kuj13HSi10UhAg1mrX4NSR5NLZzfqp6OTZf4GVGze4zlGvo7tTST6Z0m07+P GBj70tS8V6EIKUpyJfC1R5E5FMpOBq7LvgWVVAYnr3ekH0RVlooIe6iCT7S1g1Nssi09 Zur6ajPpfmbArtnPTdjVmea/uj8tu35Uie+8UrrGaYbBLcWy8kbKipBAartWwrNs5WGO 3ehw== X-Gm-Message-State: AGi0PuZKgJ3th6NuNPixptJF4jdxaGlF+kXQ5zFL6jMoFjjZgBNj3Sqp pHrfcqfN+cEmHLicZt1lPCM= X-Google-Smtp-Source: APiQypJOG6qtfSJj/AHws9ZDonzOzaRMFl/gRiPA694TiwonOAWWNZ4KP8h65Zy99Qla0QP2vjG+Dw== X-Received: by 2002:a5d:6582:: with SMTP id q2mr28911267wru.343.1588012139464; Mon, 27 Apr 2020 11:28:59 -0700 (PDT) Received: from [10.69.79.32] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id h17sm13719wmm.6.2020.04.27.11.28.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2020 11:28:58 -0700 (PDT) Subject: Re: [PATCH RFT] i2c: brcmstb: properly check NACK condition To: Wolfram Sang , linux-i2c@vger.kernel.org References: <20200426081211.10876-1-wsa+renesas@sang-engineering.com> From: Florian Fainelli Message-ID: Date: Mon, 27 Apr 2020 11:28:55 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200426081211.10876-1-wsa+renesas@sang-engineering.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_112901_320889_AE2C4B18 X-CRM114-Status: UNSURE ( 9.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , Kamal Dasu , Wolfram Sang , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/26/2020 1:12 AM, Wolfram Sang wrote: > From: Wolfram Sang > > cppcheck rightfully complains about: > > drivers/i2c/busses/i2c-brcmstb.c:319:7: warning: Condition 'CMD_RD' is always true [knownConditionTrueFalse] > drivers/i2c/busses/i2c-brcmstb.c:319:17: warning: Condition 'CMD_WR' is always false [knownConditionTrueFalse] > if ((CMD_RD || CMD_WR) && > > Compare the values to the 'cmd' variable. > > Fixes: dd1aa2524bc5 ("i2c: brcmstb: Add Broadcom settop SoC i2c controller driver") > Signed-off-by: Wolfram Sang Acked-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel