From: <Dharma.B@microchip.com>
To: <conor@kernel.org>
Cc: robh@kernel.org, alexandre.belloni@bootlin.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
claudiu.beznea@tuxon.dev, tglx@linutronix.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] dt-bindings: interrupt-controller: Convert Atmel AIC to json-schema
Date: Mon, 19 Feb 2024 15:30:52 +0000 [thread overview]
Message-ID: <a97650cd-8e06-4df6-9757-826c00a4d7cc@microchip.com> (raw)
In-Reply-To: <20240213-estranged-charger-bf0372f367e0@spud>
Hi Rob and Conor,
On 14/02/24 12:43 am, Conor Dooley wrote:
> On Tue, Feb 13, 2024 at 04:23:36AM +0000,Dharma.B@microchip.com wrote:
>> On 12/02/24 7:38 pm, Rob Herring wrote:
>>> On Fri, Feb 09, 2024 at 03:31:22PM +0530, Dharma Balasubiramani wrote:
>>>> + atmel,external-irqs:
>>>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>>>> + description: u32 array of external irqs.
>>> Constraints on the array size and/or entry values?
>> The hardware's support for external IRQs may differ, which is why a u32
>> array is utilized. This choice is based on the fact that IRQ numbers are
>> commonly expressed as integers, and a 32-bit unsigned integer provides a
>> standardized size capable of representing a broad range of numbers. This
>> size is more than adequate for accommodating IRQ numbering.
> I don't think Rob was questioning your use of u32s, but rather the fact
> that you do not limit the values at all nor the number of values.
The peripheral identification defined at the product level corresponds
to the interrupt source number.
SoC External Interrupts Peripheral ID
AT91RM9200 - IRQ0–IRQ6 25 - 31
SAMA5D2 - IRQ0–IRQn 49
SAMA5D3 - IRQ0–IRQn 47
SAMA5D4 - IRQ0–IRQn 56
SAM9x60 - IRQ0–IRQn 31
To reflect these constraints in bindings, I intend to make the following
changes.
atmel,external-irqs:
$ref: /schemas/types.yaml#/definitions/uint32-array
description: u32 array of external irqs.
if:
properties:
compatible:
contains:
const: atmel,at91rm9200-aic
then:
minItems: 1
maxItems: 7
else:
minItems: 1
maxItems: 1
--
With Best Regards,
Dharma B.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-19 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 10:01 [PATCH v2] dt-bindings: interrupt-controller: Convert Atmel AIC to json-schema Dharma Balasubiramani
2024-02-09 16:48 ` Conor Dooley
2024-02-12 14:08 ` Rob Herring
2024-02-13 4:23 ` Dharma.B
2024-02-13 19:13 ` Conor Dooley
2024-02-19 15:30 ` Dharma.B [this message]
2024-02-20 19:32 ` Conor Dooley
2024-02-22 3:41 ` Dharma.B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a97650cd-8e06-4df6-9757-826c00a4d7cc@microchip.com \
--to=dharma.b@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).