From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75EBBC4360F for ; Wed, 3 Apr 2019 09:31:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 436B121473 for ; Wed, 3 Apr 2019 09:31:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EF05+26v"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="wepfVLKE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 436B121473 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S8wfk6B3y3r8mBRrm/1M0fRB2mGLkcQwOVi2nh9S2Dk=; b=EF05+26vZiSpJ/bc1OC+66fQq 9/rsLW3xgfu1LTugNYH9DCeKl50A1LFVyotaFXfW7xaEOSOor+5AbFT2A6tX0oez/m3GQUzI9EjGp MRwpm7zSa/2T4O1+e0VHT2MjioJnLGTs9+eFcn763arDMZXOSkSVo7BSECeswP2PqiRVdgKcJlF1l iSH6r23jQWKaDh8qNDDn1Mls2+/xmMtLm0yiTykFIRB0QX57ZXyoo/EWulY2+xGqke3xdKcJfG0Q+ 9VIAydA+K5vtOiKpwFvM7wpoiTvJepfdFrGtxPmGSAj5i9nwDyqrruyV4jhyi5f1G43nfP75XmNIr jnA69NA5w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBcEw-0005Z2-0c; Wed, 03 Apr 2019 09:31:26 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBcEd-0005Gn-Ie for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2019 09:31:14 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x339V4ib011292; Wed, 3 Apr 2019 04:31:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1554283864; bh=mmudK46J15CJFT4qMmYeR4xgQWqPuI4jG+nU4vhcOjs=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=wepfVLKEqZwkoO40p7KHsugofYqTPMaZCem4wi77kshSc2M2EK+K7k6bFlR0ZP9rT tOr3AG9remTdeAZSG/3x3Shtt7h1jMl9Si6zPjFP3BCan/EWWqdvWpD3n5qlfr+n5j KrDOUGDI41KBioczfdwu0MkcUaMwlWMgrhxdMblw= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x339V4nB103943 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 3 Apr 2019 04:31:04 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 3 Apr 2019 04:31:03 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 3 Apr 2019 04:31:03 -0500 Received: from [127.0.0.1] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x339Uvam012755; Wed, 3 Apr 2019 04:30:58 -0500 Subject: Re: [PATCH 1/2] dt-bindings: clock: Add binding documentation for TI syscon gate clock To: Rob Herring , Vignesh Raghavendra References: <20190312090518.28666-1-vigneshr@ti.com> <20190312090518.28666-2-vigneshr@ti.com> <20190328123142.GA6229@bogus> From: Tero Kristo Message-ID: Date: Wed, 3 Apr 2019 12:30:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190328123142.GA6229@bogus> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190403_023107_776540_20DC0C46 X-CRM114-Status: GOOD ( 22.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , devicetree@vger.kernel.org, Stephen Boyd , Michael Turquette , linux-kernel@vger.kernel.org, Santosh Shilimkar , linux-clk@vger.kernel.org, Linux ARM Mailing List Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/03/2019 14:31, Rob Herring wrote: > On Tue, Mar 12, 2019 at 02:35:17PM +0530, Vignesh Raghavendra wrote: >> Add dt bindings for TI syscon gate clock. >> >> Signed-off-by: Vignesh Raghavendra >> --- >> .../bindings/clock/ti,syscon-gate-clock.txt | 35 +++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/ti,syscon-gate-clock.txt >> >> diff --git a/Documentation/devicetree/bindings/clock/ti,syscon-gate-clock.txt b/Documentation/devicetree/bindings/clock/ti,syscon-gate-clock.txt >> new file mode 100644 >> index 000000000000..f2bc4281ddba >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/ti,syscon-gate-clock.txt >> @@ -0,0 +1,35 @@ >> +TI syscon gate clock >> + >> +The gate clock node must be provided inside a system controller node. >> + >> +Required: >> +- comaptible: Must be "ti,syscon-gate-clock" >> +- reg: Offset of register that controls the clock within syscon regmap >> +- ti,clock-bit-idx: bit index that control gate/ungating of clock >> +- clocks: phandle to the clock parent >> +- #clock-cells: must be <0> >> + >> +Example: >> + ctrlmmr_epwm_ctrl: syscon@104140{ >> + compatible = "syscon", "simple-bus"; > > Can't be both of these... Is this a hard requirement? We seem to have few instances in the various DTS files for various vendors where this is done, syscon is paired with simple-mfd or simple-bus, or something else. Basically, syscon by itself does not probe its children, and you can't have the simple syscon support from kernel side if you don't have the syscon compatible. Alternative is that we don't add any of the syscon children under the syscon but add them as separate nodes outside it. The above is not an issue for this patch itself if we ditch the separate clock nodes, but it is more of a question about the syscon functionality itself. -Tero > >> + reg = <0x0 0x104140 0x0 0x18>; >> + ranges = <0x0 0x0 0x104140>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + ehrpwm0_tbclk: clk@0 { >> + compatible = "ti,syscon-gate-clock"; >> + reg = <0x0>; >> + #clock-cells = <0>; >> + clocks = <&k3_clks 40 0>; >> + ti,clock-bit-idx = <0>; > > This would imply you have multiple nodes at one address which is > discouraged. > >> + }; > > We generally don't describe clocks as 1 clock per node. Give the parent > a specific compatible and make it a clock provider. > >> + >> + ehrpwm1_tbclk: clk@4 { >> + compatible = "ti,syscon-gate-clock"; >> + reg = <0x4>; >> + #clock-cells = <0>; >> + clocks = <&k3_clks 41 0>; >> + ti,clock-bit-idx = <0>; >> + }; >> + }; >> -- >> 2.21.0 >> -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel