From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
Cc: linux-s390@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-aspeed@lists.ozlabs.org, linux-kbuild@vger.kernel.org,
torvalds@linux-foundation.org, linux-xtensa@linux-xtensa.org,
linux-sh@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, openrisc@lists.librecores.org,
linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH] treewide: remove bzip2 compression support
Date: Thu, 19 Nov 2020 10:21:12 +0100 [thread overview]
Message-ID: <a9a7fc22ea6fb6bdeb3274fe05a7f0d9@sf-tec.de> (raw)
In-Reply-To: <20201117223253.65920-1-alex_y_xu@yahoo.ca>
Am 2020-11-17 23:32, schrieb Alex Xu (Hello71):
> bzip2 is either slower or larger than every other supported algorithm,
> according to benchmarks at [0]. It is far slower to decompress than any
> other algorithm, and still larger than lzma, xz, and zstd.
>
> diff --git a/Documentation/x86/boot.rst b/Documentation/x86/boot.rst
> index abb9fc164657..b74d14caabe6 100644
> --- a/Documentation/x86/boot.rst
> +++ b/Documentation/x86/boot.rst
> @@ -781,10 +781,10 @@ Protocol: 2.08+
> The payload may be compressed. The format of both the compressed and
> uncompressed data should be determined using the standard magic
> numbers. The currently supported compression formats are gzip
> - (magic numbers 1F 8B or 1F 9E), bzip2 (magic number 42 5A), LZMA
> - (magic number 5D 00), XZ (magic number FD 37), LZ4 (magic number
> - 02 21) and ZSTD (magic number 28 B5). The uncompressed payload is
> - currently always ELF (magic number 7F 45 4C 46).
> + (magic numbers 1F 8B or 1F 9E), LZMA (magic number 5D 00), XZ (magic
> + number FD 37), LZ4 (magic number 02 21) and ZSTD (magic number 28
> + B5). The uncompressed payload is currently always ELF (magic number
> + 7F 45 4C 46).
>
> ============ ==============
> Field name: payload_length
> diff --git a/arch/arm/configs/aspeed_g4_defconfig
> b/arch/arm/configs/aspeed_g4_defconfig
> index 58d293b63581..f2f5dcd0e59c 100644
I would keep the magic number, and just tell that it is not supported by
newer kernels anymore if at all. It's just handy to be able to look into
the most recent documentation and see what the values are for. If you
look at an older image and don't find the magic number my first impulse
would not be to look at older versions of the documentation for things
that were removed.
Maybe something like:
"Formerly supported was also bzip2 (magic number 42 5A)."
Eike
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-19 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201117223253.65920-1-alex_y_xu.ref@yahoo.ca>
2020-11-17 22:32 ` [RFC PATCH] treewide: remove bzip2 compression support Alex Xu (Hello71)
2020-11-19 9:21 ` Rolf Eike Beer [this message]
[not found] <20201215190315.8681-1-alex_y_xu.ref@yahoo.ca>
2020-12-15 19:03 ` Alex Xu (Hello71)
2020-12-15 21:51 ` Michal Suchánek
2020-12-15 23:39 ` Alex Xu (Hello71)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9a7fc22ea6fb6bdeb3274fe05a7f0d9@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=alex_y_xu@yahoo.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=openrisc@lists.librecores.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).