From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D2CEC25B75 for ; Wed, 15 May 2024 18:34:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SMzu2OXDnULqTGEosOBbpCXEBQT7dykujj5YDSY7WZM=; b=nhJErl4x1hSmVT wHHHCqh6efwb+m/ik7fraQSS0vOAIyTGa/O+29Eb9r+PaybVZxvEAVSIBzUi2aWWfSWMV9kcEVbvy G5ThOy5P5EcB5j76c7piVycNO9d4YfnMsypTu0OeVS7QhxXX5xOExKLK44yd2lcIaMNoJJD84Y/mY ad4pVKgQBAh6r1gHtm/Kvp4ILAOPm1vnTE72iCw4LKa3FW4EVDFsvD00CepCo+mGhTvrr9r65N3+i y7k93lyR341lIsuM8Zzu3/jlAcFrchERWNQkPgOeOboDSPkGkuGz+oBjYNQ6cdl0TnysxJbGoPEW+ Iw06DsTz9cbeeHHepepA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7JSO-00000002ZDh-0QZW; Wed, 15 May 2024 18:34:28 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7JSK-00000002ZCQ-47w3 for linux-arm-kernel@lists.infradead.org; Wed, 15 May 2024 18:34:26 +0000 Received: from [10.137.186.190] (unknown [131.107.159.62]) by linux.microsoft.com (Postfix) with ESMTPSA id 9D84D20BE54C; Wed, 15 May 2024 11:34:18 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9D84D20BE54C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1715798058; bh=JiwxcyFZZClm27jDeVD6FIAV+REMJpfpKthMKDFCly0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=p8SOsXVLkMI2Zft0K4DraVsV0y+WEJsal72i3x0CZg20yVIxWlMoY9QnXl/e4VRfL CynzwiLkyK7flTJa5nq6tKqobEnw+ItmBztAYQmDwZwcdLuW++rDwgHKOgNWc6JI0z RmQezDUgoy2YpxvDGh75BWkF17gPGFvK66iqhepM= Message-ID: Date: Wed, 15 May 2024 11:34:18 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] drivers/pci/hyperv/arm64: vPCI MSI IRQ domain from DT To: Bjorn Helgaas Cc: Saurabh Singh Sengar , arnd@arndb.de, bhelgaas@google.com, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, decui@microsoft.com, haiyangz@microsoft.com, hpa@zytor.com, kw@linux.com, kys@microsoft.com, lenb@kernel.org, lpieralisi@kernel.org, mingo@redhat.com, mhklinux@outlook.com, rafael@kernel.org, robh@kernel.org, tglx@linutronix.de, wei.liu@kernel.org, will@kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, ssengar@microsoft.com, sunilmut@microsoft.com, vdso@hexbites.dev References: <20240515181238.GA2129352@bhelgaas> Content-Language: en-US From: Roman Kisel In-Reply-To: <20240515181238.GA2129352@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240515_113425_114907_200E1CC5 X-CRM114-Status: GOOD ( 18.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/15/2024 11:12 AM, Bjorn Helgaas wrote: > On Wed, May 15, 2024 at 09:34:09AM -0700, Roman Kisel wrote: >> >> >> On 5/15/2024 2:48 AM, Saurabh Singh Sengar wrote: >>> On Tue, May 14, 2024 at 03:43:53PM -0700, Roman Kisel wrote: >>>> The hyperv-pci driver uses ACPI for MSI IRQ domain configuration >>>> on arm64 thereby it won't be able to do that in the VTL mode where >>>> only DeviceTree can be used. >>>> >>>> Update the hyperv-pci driver to discover interrupt configuration >>>> via DeviceTree. >>> >>> Subject prefix should be "PCI: hv:" >>> >> Thanks! > > "git log --oneline " is a good guide in general and could be > used for other patches in this series as well. > Many thanks for suggesting that :) >>>> + hv_msi_gic_irq_domain = acpi_irq_create_hierarchy(0, HV_PCI_MSI_SPI_NR, >>>> + fn, &hv_pci_domain_ops, >>>> + chip_data); >>> >>> Upto 100 characters per line are supported now, we can have less >>> line breaks. >>> >> Fewer line breaks would make this look nicer, let me know if you had any >> particular style in mind. > > Let's not use the checkpatch "$max_line_length = 100" as a guide. > > The pci-hyperv.c file as a whole is obviously formatted to fit in 80 > columns with few exceptions. > > IMO it would not be an improvement to scatter random 100-column lines > throughout. That would just mean the file would look bad in an > 80-column terminal and there would be a lot of wasted space in a > 100-column terminal. > Appreciate showing me the data-driven way of reasoning about that very much! > Bjorn -- Thank you, Roman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel