From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D599C433E3 for ; Thu, 27 Aug 2020 10:45:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C30A207F7 for ; Thu, 27 Aug 2020 10:45:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rGhdk7eL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C30A207F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TqG2CMwsqkiD3CRjj2LmSRhEdoS4coC7dZ9kW+XLM/4=; b=rGhdk7eLElqRe2c/PeWNnXDEA awGUa5hFekDgBTZsAdSMgXV/9CTiuqIUr8Dt6z50WJfxSNOAdAOcXYUhnv3Z6iea43guiByl5gWCP 9yBdfD2nuwsNbLWOhtVnCNSGNDnT3QNXvZmJESCf00Av7Urr4f4GF5vgFzaon5f4U+J8UxwGmOZcT hzOCa/75gxatHs5Qgn6bKd+i7YPWa1ZbO5QBU0MShJ31x/VqPPtFSCKi7MbgQhwQ92IxQN4hheqHO Dtw7RJWDGbySXRvM1mO9VfXk/SZSJo6ehtwt6FgB5alh6Xo+AYUnkoPhQ3fuLlofQxxInYpIZ3KcG 6oKskdeaQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBFO0-0000Qt-JN; Thu, 27 Aug 2020 10:44:04 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBFNx-0000Ps-Ci for linux-arm-kernel@lists.infradead.org; Thu, 27 Aug 2020 10:44:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07723101E; Thu, 27 Aug 2020 03:43:57 -0700 (PDT) Received: from [192.168.1.190] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EF7063F66B; Thu, 27 Aug 2020 03:43:53 -0700 (PDT) Subject: Re: [PATCH 22/35] arm64: mte: Enable in-kernel MTE To: Catalin Marinas , Andrey Konovalov References: <6a83a47d9954935d37a654978e96c951cc56a2f6.1597425745.git.andreyknvl@google.com> <20200827100155.GD29264@gaia> From: Vincenzo Frascino Message-ID: Date: Thu, 27 Aug 2020 11:46:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200827100155.GD29264@gaia> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200827_064401_502765_725AFEA1 X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Elena Petrova , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/27/20 11:01 AM, Catalin Marinas wrote: > On Fri, Aug 14, 2020 at 07:27:04PM +0200, Andrey Konovalov wrote: >> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c >> index 4d3abb51f7d4..4d94af19d8f6 100644 >> --- a/arch/arm64/kernel/cpufeature.c >> +++ b/arch/arm64/kernel/cpufeature.c >> @@ -1670,6 +1670,9 @@ static void cpu_enable_mte(struct arm64_cpu_capabilities const *cap) >> write_sysreg_s(0, SYS_TFSR_EL1); >> write_sysreg_s(0, SYS_TFSRE0_EL1); >> >> + /* Enable Match-All at EL1 */ >> + sysreg_clear_set(tcr_el1, 0, SYS_TCR_EL1_TCMA1); >> + >> /* >> * CnP must be enabled only after the MAIR_EL1 register has been set >> * up. Inconsistent MAIR_EL1 between CPUs sharing the same TLB may >> @@ -1687,6 +1690,9 @@ static void cpu_enable_mte(struct arm64_cpu_capabilities const *cap) >> mair &= ~MAIR_ATTRIDX(MAIR_ATTR_MASK, MT_NORMAL_TAGGED); >> mair |= MAIR_ATTRIDX(MAIR_ATTR_NORMAL_TAGGED, MT_NORMAL_TAGGED); >> write_sysreg_s(mair, SYS_MAIR_EL1); >> + >> + /* Enable MTE Sync Mode for EL1 */ >> + sysreg_clear_set(sctlr_el1, SCTLR_ELx_TCF_MASK, SCTLR_ELx_TCF_SYNC); > > In the 8th incarnation of the user MTE patches, this initialisation > moved to proc.S before the MMU is initialised. When rebasing, please > take this into account. > Thank you for the heads up. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel