From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82A26C433F5 for ; Wed, 4 May 2022 08:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7XLWqmHTXjLIR9FFSClZOeVK2UO/jBsro8qiArzzLs8=; b=jSlUXDwGorLv9q haNHzaCGXMn6I9nMsIYMkrGCnUNUpOc15A3IsZqpWvM4gbhCRJC14T9N0zySqA+K1GU++TwDGOjt9 RWZYYO9wDsD4yfnOJFyAJhpxWy7g3xAWy9eeKHLojvknKNabY6wxwbpNc4V8bfjBGSp6UIUuMBR4P cFIHhr60xxY8FYQJUZpER9ONzrdC1SPay8vD1zmwwO/Q2lX6mMZUclY+LOFddF2zz7npcrhXceX06 JLL1i9UNz2hkvnS6n8abAvpX+FiGtFg7J4YaaJMoFjEq/bCmogHrXnw/222yrACti/fQ26Kw06yr2 C9VE7oqrelUJ3UP3TyPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmAo2-009gP5-6O; Wed, 04 May 2022 08:56:22 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmAny-009gNS-NH for linux-arm-kernel@lists.infradead.org; Wed, 04 May 2022 08:56:20 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmAnm-0001l6-DB; Wed, 04 May 2022 10:56:06 +0200 Message-ID: Subject: Re: [PATCH v4 00/11] consolidated i.MX8MP HSIO/MEDIA/HDMI blk-ctrl series From: Lucas Stach To: Laurent Pinchart Cc: Shawn Guo , Rob Herring , Krzysztof Kozlowski , Marek Vasut , devicetree@vger.kernel.org, Paul Elder , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Date: Wed, 04 May 2022 10:56:05 +0200 In-Reply-To: References: <20220406153402.1265474-1-l.stach@pengutronix.de> <8c29464ef118aae8a1ac2af28d4906a346b6028a.camel@pengutronix.de> User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_015618_815798_7D9974A3 X-CRM114-Status: GOOD ( 43.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, dem 04.05.2022 um 11:48 +0300 schrieb Laurent Pinchart: > Hi Lucas, > > On Wed, May 04, 2022 at 10:27:01AM +0200, Lucas Stach wrote: > > Hi Shawn, > > > > there were some comments about the implementation of the HDMI blk-ctrl, > > which I don't know in which way to resolve, yet. In the meantime it > > would be very helpful if you could take all but the last patch of this > > series into your tree. They are all reviewed and tested and starting to > > block further work on some parts of the i.MX8MP bringup. > > Can we decouple the HDMI blk-ctrl from the rest, to at least upstream > the MEDIA blk-ctrl ? That part is ready. > I've structured the series in such a way that the HDMI part is decoupled already. All that needs to be done is dropping the last patch. Regards, Lucas > > Am Mittwoch, dem 06.04.2022 um 17:33 +0200 schrieb Lucas Stach: > > > Hi all, > > > > > > this series adds a bunch more power domains that integrate with the blk-ctrls > > > to the i.MX8MP. It depends on the i.MX8MP GPCv2 support series posted in [1]. > > > > > > The HSIO blk-ctrl bindings are already applied upstream, so they are not part > > > of this series anymore. The DT description hasn't changed, but the > > > implementation of the HSIO blk-ctrl driver is reworked quite a bit from the > > > last round of patches, so I've dropped the review/tested-by tags. > > > > > > I've also picked up the pretty thoroughly reviewed and tested MEDIA blk-ctrl > > > patches from Paul and Laurent into this series, as they would conflict with > > > other patches from this series when applied separately. This should hopefully > > > make it easier for Shawn to pick things up. > > > > > > Finally this now also adds the HDMI blk-ctrl, not part of any previous series. > > > This one is pretty complex and the documentation in the reference manual > > > appears to be inaccurate. I found at least the following issues: > > > > > > 1. GLOBAL_XTAL24M_CLK_EN does not actually gate the 24MHz reference clock, > > > the PHY PLL happily locks and provides correct clocks without this clock being > > > ungated. It seems to gate some clock input of the HDMI TX controller instead, > > > register access to this controller fails without this clock. > > > > > > 2. HDMI_RTX_RESET_CTL0 bits 6 and 7 are marked as "reserved" in the manual, > > > but they are actually required to be configured. Bit 6 seems to keep something > > > in the display pixel clock path in inactive state and Bit 7 seems to reset > > > the HDMI TX i2c controller. > > > > > > The HDMI blk-ctrl part is tested quite extensively with a PoC HDMI support > > > patchset, which I will send out in a bit, so I'm pretty sure that the > > > support as implemented is working. I've put the patches last in the series > > > in case that this turns out to be controversial, so the other patches can > > > be applied independent from the HDMI support. > > > > > > Regards, > > > Lucas > > > > > > [1] https://lore.kernel.org/all/20220330104620.3600159-1-l.stach@pengutronix.de/ > > > > > > > > > Laurent Pinchart (1): > > > arm64: dts: imx8mp: Add MEDIAMIX power domains > > > > > > Lucas Stach (7): > > > soc: imx: imx8m-blk-ctrl: set power device name > > > soc: imx: add i.MX8MP HSIO blk-ctrl > > > dt-bindings: power: imx8mp: add defines for HDMI blk-ctrl domains > > > dt-bindings: soc: add binding for i.MX8MP HDMI blk-ctrl > > > soc: imx: add i.MX8MP HDMI blk-ctrl > > > arm64: dts: imx8mp: add HSIO power-domains > > > arm64: dts: imx8mp: add HDMI power-domains > > > > > > Paul Elder (3): > > > dt-bindings: soc: Add i.MX8MP media block control DT bindings > > > soc: imx: imx8m-blk-ctrl: Add i.MX8MP media blk-ctrl > > > arm64: dts: imx8mp: Add MEDIA_BLK_CTRL > > > > > > .../soc/imx/fsl,imx8mp-hdmi-blk-ctrl.yaml | 84 +++ > > > .../soc/imx/fsl,imx8mp-media-blk-ctrl.yaml | 104 +++ > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 153 +++- > > > drivers/soc/imx/Makefile | 1 + > > > drivers/soc/imx/imx8m-blk-ctrl.c | 124 +++- > > > drivers/soc/imx/imx8mp-blk-ctrl.c | 696 ++++++++++++++++++ > > > include/dt-bindings/power/imx8mp-power.h | 18 + > > > 7 files changed, 1172 insertions(+), 8 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-hdmi-blk-ctrl.yaml > > > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > > > create mode 100644 drivers/soc/imx/imx8mp-blk-ctrl.c > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel