linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: niam.niam@gmail.com (Ni@m)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] jffs2: fix memory leak if the sector was successfully erased
Date: Mon, 22 Feb 2010 18:26:22 +0200	[thread overview]
Message-ID: <a9e22dff1002220826p63209a33n27e84ea10e191a19@mail.gmail.com> (raw)

Memory allocated for erase instruction is not freed if the sector was
successfully erased.

Signed-off-by: Dmytro Milinevskyy <niam.niam@gmail.com>
---
 fs/jffs2/erase.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/jffs2/erase.c b/fs/jffs2/erase.c
index b47679b..c0a5604 100644
--- a/fs/jffs2/erase.c
+++ b/fs/jffs2/erase.c
@@ -74,8 +74,10 @@ static void jffs2_erase_block(struct jffs2_sb_info *c,
        ((struct erase_priv_struct *)instr->priv)->c = c;

        ret = c->mtd->erase(c->mtd, instr);
-       if (!ret)
+       if (!ret) {
+        kfree(instr);
                return;
+    }

        bad_offset = instr->fail_addr;
        kfree(instr);

             reply	other threads:[~2010-02-22 16:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-22 16:26 Ni@m [this message]
2010-02-22 16:33 ` [PATCH] jffs2: fix memory leak if the sector was successfully erased Russell King - ARM Linux
2010-02-22 16:35 ` Daniel Mack
2010-02-22 17:28   ` Michael Trimarchi
2010-02-22 17:40     ` niam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9e22dff1002220826p63209a33n27e84ea10e191a19@mail.gmail.com \
    --to=niam.niam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).