Re: [PATCH v2 08/22] iommufd: Abstract iopt_pin_pages and iopt_unpin_pages helpers

Nicolin Chen
2025-04-28T22:15:05Z

On Mon, Apr 28, 2025 at 08:14:19PM +0000, Pranjal Shrivastava wrote:
> On Fri, Apr 25, 2025 at 10:58:03PM -0700, Nicolin Chen wrote:
> > + iopt_for_each_contig_area(&iter, area, iopt, iova, last_iova) {
> > + unsigned long last = min(last_iova, iopt_area_last_iova(area));
> > + unsigned long last_index = iopt_area_iova_to_index(area, last);
> > + unsigned long index =
> > + iopt_area_iova_to_index(area, iter.cur_iova);
> > +
> > + if (area->prevent_access ||
>
> Nit:
> Shouldn't we return -EBUSY or something if (area->prevent_access == 1) ?
> IIUC, this just means that an unmap attempt is in progress, hence avoid
> accessing the area.

Maybe. But this is what it was. So we need a different patch to
change that.

Thanks
Nicolin