Re: [PATCH v2 21/22] iommu/tegra241-cmdqv: Add user-space use support

Nicolin Chen
2025-04-29T21:15:10Z

On Wed, Apr 30, 2025 at 01:17:48AM +0530, ALOK TIWARI wrote:
> > + /*
> > + * @length must be a power of 2, in range of
> > + * [ 32, 1 ^ (idr[1].CMDQS + CMDQ_ENT_SZ_SHIFT) ]
>
> 2 ^ (idr[1].CMDQS + CMDQ_ENT_SZ_SHIFT) or 1 << idr[1].CMDQS
>
> > + */
> > + max_n_shift = FIELD_GET(IDR1_CMDQS,
> > + readl_relaxed(smmu->base + ARM_SMMU_IDR1));
>
>
> LGTM, aside from a minor cosmetic thing.

Fixed all those and the typo in the other mail. Picked "2 ^ " btw.

Thanks
Nicolin