Re: [PATCH 00/11] mmc: rename mmc_retune_* to mmc_host_retune_*

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

Hi Ulf,

uuuh, I overlooked this mail, sorry!

> Sorry if my suggestion was unclear. I only had the MMC_CAP|CAP2_*
> related functions in mind. I think we should leave the mmc_retune*
> functions as is as they are not "can" functions.

I agree. I suggested that in my initial series, too.

> mmc_host_cmd23, mmc_host_done_complete, mmc_boot_partition_access,
> mmc_host_uhs. All in drivers/mmc/core/host.h
> 
> According to your earlier renaming series, we should rename these function too:
> mmc_host_can_cmd23, mmc_host_can_done_complete,
> mmc_host_can_boot_partition, mmc_host_can_uhs
> 
> Does this make sense to you?

I don't know these functions well, so you are probably right. I'll look
into it. One question: do you really suggest:

mmc_boot_partition_access -> mmc_host_can_boot_partition

or should it be:

mmc_boot_partition_access -> mmc_host_can_boot_partition_access

? I tend to think the first is better, just making sure.

Happy hacking,

   Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]