From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91FAAC369C9 for ; Thu, 17 Apr 2025 16:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F74nRVGkd2m8J5KZtzQY737upkU+XgKU1j7nwBIitzA=; b=4xdZk3ciqqGneucF5IX5i8+qBt IKT5LMfs0wZBlgDvUT4PWoQ5Apbf+OuEIq2kx+/WQDM0fWWAyvEEBXXIZgaRARtLfc+6j+XdAeKzw 4P5dJ2VeePdRxdMU5GVrPNm1sPbwaR5TrTqX05wfhG8BXM7aC+JpJK5Cy+F3M+TquY/Qkh5orFRUN 02TpVhm0RxMX4G8IWMyY/UpM56ncsQO1rbTPY48vRhf5j3jQ22EigYaWUU6B12Dt11j07ff8WLcOy ujjYu1QUjkLN0b8GiOQXqrW5+//mvNYSVzXevRJuhCXnkUSkHpHSUSKxeys4R3xHORlAWawpS2D3c XQeAAKLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u5SBV-0000000DgWb-2C8k; Thu, 17 Apr 2025 16:33:53 +0000 Received: from pidgin.makrotopia.org ([2a07:2ec0:3002::65]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u5Rv7-0000000Ddij-2rjF; Thu, 17 Apr 2025 16:16:58 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98.2) (envelope-from ) id 1u5RsR-000000002Q4-0DCF; Thu, 17 Apr 2025 16:16:49 +0000 Date: Thu, 17 Apr 2025 17:16:45 +0100 From: Daniel Golle To: Jakub Kicinski Cc: Felix Fietkau , Sean Wang , Lorenzo Bianconi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net v2 4/5] net: ethernet: mtk_eth_soc: net: revise NETSYSv3 hardware configuration Message-ID: References: <8ab7381447e6cdcb317d5b5a6ddd90a1734efcb0.1744764277.git.daniel@makrotopia.org> <28929b5bb2bfd45e040a07c0efefb29e57a77513.1744764277.git.daniel@makrotopia.org> <20250417081055.1bda2ff6@kernel.org> <20250417085948.35b0ec5a@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250417085948.35b0ec5a@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250417_091657_722295_CCAEDB97 X-CRM114-Status: GOOD ( 22.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 17, 2025 at 08:59:48AM -0700, Jakub Kicinski wrote: > On Thu, 17 Apr 2025 16:45:14 +0100 Daniel Golle wrote: > > On Thu, Apr 17, 2025 at 08:10:55AM -0700, Jakub Kicinski wrote: > > > On Wed, 16 Apr 2025 01:51:42 +0100 Daniel Golle wrote: > > > > + /* PSE should not drop port8, port9 and port13 packets from WDMA Tx */ > > > > + mtk_w32(eth, 0x00002300, PSE_DROP_CFG); > > > > + > > > > + /* PSE should drop packets to port8, port9 and port13 on WDMA Rx ring full */ > > > > > > nit: please try to wrap at 80 chars. There's really no need to go over > > > on comments. Some of us stick to 80 char terminals. > > > > Too late now to send another revision... > > I only applied the first 3 :) Perfect, so I'll roll up the remaining two with the changes suggested. > > > > > [...] > > > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h > > > > index 39709649ea8d1..eaa96c8483b70 100644 > > > > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.h > > > > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.h > > > > @@ -151,7 +151,12 @@ > > > > #define PSE_FQFC_CFG1 0x100 > > > > #define PSE_FQFC_CFG2 0x104 > > > > #define PSE_DROP_CFG 0x108 > > > > -#define PSE_PPE0_DROP 0x110 > > > > +#define PSE_PPE_DROP(x) (0x110 + ((x) * 0x4)) > > > > + > > > > +/* PSE Last FreeQ Page Request Control */ > > > > +#define PSE_DUMY_REQ 0x10C > > > > > > This really looks like misspelling of DUMMY, is it really supposed > > > to have one 'M' ? > > > > I also thought that when I first saw that and have told MediaTek engineers > > about it, they told me that the register is called like that also in their > > datasheet and hence they want the name to be consistent in the driver. > > Hm, maybe add a comment ? It confused both of us, probably going > to confuse most people later on Ok, will do and send v3. Thank you!