* [PATCH next] pinctrl: mediatek: common-v1: Fix error checking in mtk_eint_init()
@ 2025-04-23 8:23 Dan Carpenter
2025-04-23 10:59 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-04-23 8:23 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Sean Wang, Linus Walleij, Matthias Brugger,
AngeloGioacchino Del Regno, linux-mediatek, linux-gpio,
linux-kernel, linux-arm-kernel, kernel-janitors
The devm_kzalloc() function doesn't return error pointers, it returns
NULL on error. Then on the next line it checks the same pointer again
by mistake, "->base" instead of "->base[0]".
Fixes: fe412e3a6c97 ("pinctrl: mediatek: common-v1: Fix EINT breakage on older controllers")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
index 7585de11854b..8596f3541265 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
@@ -1018,12 +1018,12 @@ static int mtk_eint_init(struct mtk_pinctrl *pctl, struct platform_device *pdev)
pctl->eint->nbase = 1;
/* mtk-eint expects an array */
pctl->eint->base = devm_kzalloc(pctl->dev, sizeof(pctl->eint->base), GFP_KERNEL);
- if (IS_ERR(pctl->eint->base))
+ if (!pctl->eint->base)
return -ENOMEM;
pctl->eint->base[0] = devm_platform_ioremap_resource(pdev, 0);
- if (IS_ERR(pctl->eint->base))
- return PTR_ERR(pctl->eint->base);
+ if (IS_ERR(pctl->eint->base[0]))
+ return PTR_ERR(pctl->eint->base[0]);
pctl->eint->irq = irq_of_parse_and_map(np, 0);
if (!pctl->eint->irq)
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH next] pinctrl: mediatek: common-v1: Fix error checking in mtk_eint_init()
2025-04-23 8:23 [PATCH next] pinctrl: mediatek: common-v1: Fix error checking in mtk_eint_init() Dan Carpenter
@ 2025-04-23 10:59 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2025-04-23 10:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Chen-Yu Tsai, Sean Wang, Matthias Brugger,
AngeloGioacchino Del Regno, linux-mediatek, linux-gpio,
linux-kernel, linux-arm-kernel, kernel-janitors
On Wed, Apr 23, 2025 at 10:23 AM Dan Carpenter <dan.carpenter@linaro.org> wrote:
> The devm_kzalloc() function doesn't return error pointers, it returns
> NULL on error. Then on the next line it checks the same pointer again
> by mistake, "->base" instead of "->base[0]".
>
> Fixes: fe412e3a6c97 ("pinctrl: mediatek: common-v1: Fix EINT breakage on older controllers")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Patch applied for fixes as a fix on fix.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-23 12:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-23 8:23 [PATCH next] pinctrl: mediatek: common-v1: Fix error checking in mtk_eint_init() Dan Carpenter
2025-04-23 10:59 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).