From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89107C369D7 for ; Wed, 23 Apr 2025 09:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cTTTAQDf6fHnIShOY7nHVrkl1CzARvdCJOI3IZdV3Ac=; b=1lU3tR+7pjwfY+8Hgi4+961ngE gEHYXcDVrJYtBQwx2xnSxFlBV/peOxNAcc9yAp2O6bBWsgi+1/3b+jW0rX/H8R6cXjz9nYdN7fSS7 S88alai54hg19oa+ZE2bypZ7wx+6vb+UqB3njKh8E3WGoKfKAkq92AiUaDgjouFtAa18KsoOHmpIX 2HNJPn4UVtaT0Ig0KiAP8ZfnJy1ODOf041LTUqf8Cc/k78X7cv0SlqUNzCDUTvEDxKHu/n/x0wWGv O6WloO8+7VzccKO59u8k8VwLQ9vC+o/4IYlUiZOKLARHdFjDBv6Ai4ahMngEtOItBriGSa/YyIFxX NRCasB2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7WjR-0000000A3r3-1uLl; Wed, 23 Apr 2025 09:49:29 +0000 Received: from mail-m16.yeah.net ([220.197.32.19]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7ViQ-00000009o8c-2iKD for linux-arm-kernel@lists.infradead.org; Wed, 23 Apr 2025 08:44:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=cTTTAQDf6fHnIShOY7nHVrkl1CzARvdCJOI3IZdV3Ac=; b=mPONR0tJ6JOAJK6st/hPw4OWfYhiQ3c37toLpvSvAaTUNYLlNVJC1R9nNG+9bO H8o+3/NoDauh6x0yPfh+wYor+sUeJSUF4A25f5qsCk4oitUYlN9mKUDmXZZeIpqs hptJqog/aAY1kmbLxXjDx5rYnCbMdc1NB+fa+38LBlu4Q= Received: from dragon (unknown []) by gzsmtp1 (Coremail) with SMTP id Mc8vCgD39tU8qAhoAhnAAw--.25448S3; Wed, 23 Apr 2025 16:43:42 +0800 (CST) Date: Wed, 23 Apr 2025 16:43:40 +0800 From: Shawn Guo To: Alexander Stein Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux@ew.tq-group.com Subject: Re: [PATCH 2/2] arm64: dts: imx8mp-tqma8mpql-mba8mp-ras314: Add Raspberry Pi Camera V2 overlay Message-ID: References: <20250324071102.23765-1-alexander.stein@ew.tq-group.com> <20250324071102.23765-2-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250324071102.23765-2-alexander.stein@ew.tq-group.com> X-CM-TRANSID: Mc8vCgD39tU8qAhoAhnAAw--.25448S3 X-Coremail-Antispam: 1Uf129KBjvJXoWxXrWDKFyfXrWkJrWxJFWfGrg_yoWrKryfpr n7Ca93GFs7Jr4xAwsIqrnIgrn0y3y8GF4jvr1UAry8Cr129FyxtF90qr15urWfWFnFv3yj vF92qry2gFnIqaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jO8nOUUUUU= X-Originating-IP: [114.216.210.34] X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiEQ04ZWgIgd2b8QAAsX X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250423_014423_064916_333C7F5D X-CRM114-Status: GOOD ( 16.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 24, 2025 at 08:11:00AM +0100, Alexander Stein wrote: > This overlay configures IMX219 MIPI-CSI-2 camera attached to ISP1. > Also add additional overlay both using LVDS display and camera. > > Signed-off-by: Alexander Stein > --- > arch/arm64/boot/dts/freescale/Makefile | 4 + > ...imx8mp-tqma8mpql-mba8mp-ras314-imx219.dtso | 107 ++++++++++++++++++ > 2 files changed, 111 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314-imx219.dtso > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index d7ac8dda4bde5..b5cd2efd260cb 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -247,10 +247,14 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk-pcie-ep.dtb > > imx8mp-tqma8mpql-mba8mpxl-lvds-dtbs += imx8mp-tqma8mpql-mba8mpxl.dtb imx8mp-tqma8mpql-mba8mpxl-lvds.dtbo > imx8mp-tqma8mpql-mba8mpxl-lvds-g133han01-dtbs += imx8mp-tqma8mpql-mba8mpxl.dtb imx8mp-tqma8mpql-mba8mpxl-lvds-g133han01.dtbo > +imx8mp-tqma8mpql-mba8mp-ras314-imx219-dtbs += imx8mp-tqma8mpql-mba8mp-ras314.dtb imx8mp-tqma8mpql-mba8mp-ras314-imx219.dtbo > imx8mp-tqma8mpql-mba8mp-ras314-lvds-dtbs += imx8mp-tqma8mpql-mba8mp-ras314.dtb imx8mp-tqma8mpql-mba8mpxl-lvds.dtbo > +imx8mp-tqma8mpql-mba8mp-ras314-lvds-imx219-dtbs += imx8mp-tqma8mpql-mba8mp-ras314.dtb imx8mp-tqma8mpql-mba8mpxl-lvds.dtbo imx8mp-tqma8mpql-mba8mp-ras314-imx219.dtbo > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl-lvds.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl-lvds-g133han01.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mp-ras314-imx219.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mp-ras314-lvds.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mp-ras314-lvds-imx219.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mq-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-hummingboard-pulse.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314-imx219.dtso b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314-imx219.dtso > new file mode 100644 > index 0000000000000..0bc96d242f33f > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mp-ras314-imx219.dtso > @@ -0,0 +1,107 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +/* > + * Copyright 2022-2025 TQ-Systems GmbH , > + * D-82229 Seefeld, Germany. > + * Author: Alexander Stein > + */ > +/dts-v1/; > +/plugin/; > + > +#include > +#include > + > +#include "imx8mp-pinfunc.h" > + > +&{/} { > + /* > + * The three camera regulators are controlled by a single GPIO. Declare > + * a single regulator for the three supplies. > + */ > + reg_cam: regulator-cam { > + compatible = "regulator-fixed"; > + regulator-name = "reg_cam"; > + /* pad muxing already done in gpio2grp */ > + gpio = <&gpio2 6 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + vin-supply = <®_vcc_3v3>; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + cam24m: cam24m { Can we name the node clock-cam24m? > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <24000000>; > + clock-output-names = "cam24m"; > + }; > +}; > + > +&i2c2 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + camera@1a { > + compatible = "sony,imx219"; > + reg = <0x10>; 'reg' doesn't match unit address. Shawn > + clocks = <&cam24m>; > + VANA-supply = <®_cam>; > + VDIG-supply = <®_cam>; > + VDDL-supply = <®_cam>; > + orientation = <2>; > + rotation = <0>; > + > + port { > + sony_imx219: endpoint { > + remote-endpoint = <&imx8mp_mipi_csi_in>; > + clock-lanes = <0>; > + clock-noncontinuous; > + data-lanes = <1 2>; > + link-frequencies = /bits/ 64 <456000000>; > + }; > + }; > + }; > +}; > + > +&isi_0 { > + status = "disabled"; > + > + ports { > + port@0 { > + /delete-node/ endpoint; > + }; > + }; > +}; > + > +&isp_0 { > + status = "okay"; > + > + ports { > + port@1 { > + isp0_in: endpoint { > + bus-type = ; > + remote-endpoint = <&mipi_csi_0_out>; > + }; > + }; > + }; > +}; > + > +&mipi_csi_0 { > + status = "okay"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + imx8mp_mipi_csi_in: endpoint { > + remote-endpoint = <&sony_imx219>; > + clock-lanes = <0>; > + data-lanes = <1 2>; > + }; > + }; > + }; > +}; > + > +&mipi_csi_0_out { > + remote-endpoint = <&isp0_in>; > +}; > -- > 2.43.0 >