* [PATCH 1/2] remoteproc: imx_rproc: release carveout under imx_rproc after rproc_attach() fails
@ 2025-04-24 12:22 Xiaolei Wang
2025-04-24 12:22 ` [PATCH 2/2] remoteproc: core: release rproc->clean_table " Xiaolei Wang
2025-04-25 16:47 ` [PATCH 1/2] remoteproc: imx_rproc: release carveout under imx_rproc " Mathieu Poirier
0 siblings, 2 replies; 4+ messages in thread
From: Xiaolei Wang @ 2025-04-24 12:22 UTC (permalink / raw)
To: andersson, mathieu.poirier, shawnguo, festevam
Cc: xiaolei.wang, kernel, linux-remoteproc, linux-arm-kernel, imx,
linux-kernel
Release all carveouts under imx_rproc after rproc_attach() fails to solve
the following kmemleak:
unreferenced object 0xffff0000861c5d00 (size 128):
comm "kworker/u12:3", pid 59, jiffies 4294893509 (age 149.220s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 02 88 00 00 00 00 00 00 10 00 00 00 00 00 ............
backtrace:
[<00000000f949fe18>] slab_post_alloc_hook+0x98/0x37c
[<00000000adbfb3e7>] __kmem_cache_alloc_node+0x138/0x2e0
[<00000000521c0345>] kmalloc_trace+0x40/0x158
[<000000004e330a49>] rproc_mem_entry_init+0x60/0xf8
[<000000002815755e>] imx_rproc_prepare+0xe0/0x180
[<0000000003f61b4e>] rproc_boot+0x2ec/0x528
[<00000000e7e994ac>] rproc_add+0x124/0x17c
[<0000000048594076>] imx_rproc_probe+0x4ec/0x5d4
[<00000000efc298a1>] platform_probe+0x68/0xd8
[<00000000110be6fe>] really_probe+0x110/0x27c
[<00000000e245c0ae>] __driver_probe_device+0x78/0x12c
[<00000000f61f6f5e>] driver_probe_device+0x3c/0x118
[<00000000a7874938>] __device_attach_driver+0xb8/0xf8
[<0000000065319e69>] bus_for_each_drv+0x84/0xe4
[<00000000db3eb243>] __device_attach+0xfc/0x18c
[<0000000072e4e1a4>] device_initial_probe+0x14/0x20
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
drivers/remoteproc/imx_rproc.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 74299af1d7f1..c489bd15ee91 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -595,6 +595,19 @@ static int imx_rproc_prepare(struct rproc *rproc)
return 0;
}
+static int imx_rproc_unprepare(struct rproc *rproc)
+{
+ struct rproc_mem_entry *entry, *tmp;
+
+ rproc_coredump_cleanup(rproc);
+ /* clean up carveout allocations */
+ list_for_each_entry_safe(entry, tmp, &rproc->carveouts, node) {
+ list_del(&entry->node);
+ kfree(entry);
+ }
+ return 0;
+}
+
static int imx_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw)
{
int ret;
@@ -675,6 +688,7 @@ imx_rproc_elf_find_loaded_rsc_table(struct rproc *rproc, const struct firmware *
static const struct rproc_ops imx_rproc_ops = {
.prepare = imx_rproc_prepare,
+ .unprepare = imx_rproc_unprepare,
.attach = imx_rproc_attach,
.detach = imx_rproc_detach,
.start = imx_rproc_start,
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] remoteproc: core: release rproc->clean_table after rproc_attach() fails
2025-04-24 12:22 [PATCH 1/2] remoteproc: imx_rproc: release carveout under imx_rproc after rproc_attach() fails Xiaolei Wang
@ 2025-04-24 12:22 ` Xiaolei Wang
2025-04-25 16:47 ` [PATCH 1/2] remoteproc: imx_rproc: release carveout under imx_rproc " Mathieu Poirier
1 sibling, 0 replies; 4+ messages in thread
From: Xiaolei Wang @ 2025-04-24 12:22 UTC (permalink / raw)
To: andersson, mathieu.poirier, shawnguo, festevam
Cc: xiaolei.wang, kernel, linux-remoteproc, linux-arm-kernel, imx,
linux-kernel
When rproc_attach() fails release rproc->clean_table to
solve the following kmemleak:
unreferenced object 0xffff000086a99800 (size 1024):
comm "kworker/u12:3", pid 59, jiffies 4294893670 (age 121.140s)
hex dump (first 32 bytes):
00 00 00 00 00 80 00 00 00 00 00 00 00 00 10 00 ............
00 00 00 00 00 00 08 00 00 00 00 00 00 00 00 00 ............
backtrace:
[<000000008bbe4ca8>] slab_post_alloc_hook+0x98/0x3fc
[<000000003b8a272b>] __kmem_cache_alloc_node+0x13c/0x230
[<000000007a507c51>] __kmalloc_node_track_caller+0x5c/0x260
[<0000000037818dae>] kmemdup+0x34/0x60
[<00000000610f7f57>] rproc_boot+0x35c/0x56c
[<0000000065f8871a>] rproc_add+0x124/0x17c
[<00000000497416ee>] imx_rproc_probe+0x4ec/0x5d4
[<000000003bcaa37d>] platform_probe+0x68/0xd8
[<00000000771577f9>] really_probe+0x110/0x27c
[<00000000531fea59>] __driver_probe_device+0x78/0x12c
[<0000000080036a04>] driver_probe_device+0x3c/0x118
[<000000007e0bddcb>] __device_attach_driver+0xb8/0xf8
[<000000000cf1fa33>] bus_for_each_drv+0x84/0xe4
[<000000001a53b53e>] __device_attach+0xfc/0x18c
[<00000000d1a2a32c>] device_initial_probe+0x14/0x20
[<00000000d8f8b7ae>] bus_probe_device+0xb0/0xb4
unreferenced object 0xffff0000864c9690 (size 16):
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
drivers/remoteproc/remoteproc_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index b21eedefff87..6226e2d12a97 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -1656,6 +1656,7 @@ static int rproc_attach(struct rproc *rproc)
unprepare_device:
/* release HW resources if needed */
rproc_unprepare_device(rproc);
+ kfree(rproc->clean_table);
disable_iommu:
rproc_disable_iommu(rproc);
return ret;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] remoteproc: imx_rproc: release carveout under imx_rproc after rproc_attach() fails
2025-04-24 12:22 [PATCH 1/2] remoteproc: imx_rproc: release carveout under imx_rproc after rproc_attach() fails Xiaolei Wang
2025-04-24 12:22 ` [PATCH 2/2] remoteproc: core: release rproc->clean_table " Xiaolei Wang
@ 2025-04-25 16:47 ` Mathieu Poirier
2025-04-26 0:07 ` xiaolei wang
1 sibling, 1 reply; 4+ messages in thread
From: Mathieu Poirier @ 2025-04-25 16:47 UTC (permalink / raw)
To: Xiaolei Wang
Cc: andersson, shawnguo, festevam, kernel, linux-remoteproc,
linux-arm-kernel, imx, linux-kernel
On Thu, Apr 24, 2025 at 08:22:51PM +0800, Xiaolei Wang wrote:
> Release all carveouts under imx_rproc after rproc_attach() fails to solve
> the following kmemleak:
>
Please provide more details on the steps needed to reproduce this problem and
where in rproc_attach() the original failure occured.
Thanks,
Mathieu
> unreferenced object 0xffff0000861c5d00 (size 128):
> comm "kworker/u12:3", pid 59, jiffies 4294893509 (age 149.220s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 02 88 00 00 00 00 00 00 10 00 00 00 00 00 ............
> backtrace:
> [<00000000f949fe18>] slab_post_alloc_hook+0x98/0x37c
> [<00000000adbfb3e7>] __kmem_cache_alloc_node+0x138/0x2e0
> [<00000000521c0345>] kmalloc_trace+0x40/0x158
> [<000000004e330a49>] rproc_mem_entry_init+0x60/0xf8
> [<000000002815755e>] imx_rproc_prepare+0xe0/0x180
> [<0000000003f61b4e>] rproc_boot+0x2ec/0x528
> [<00000000e7e994ac>] rproc_add+0x124/0x17c
> [<0000000048594076>] imx_rproc_probe+0x4ec/0x5d4
> [<00000000efc298a1>] platform_probe+0x68/0xd8
> [<00000000110be6fe>] really_probe+0x110/0x27c
> [<00000000e245c0ae>] __driver_probe_device+0x78/0x12c
> [<00000000f61f6f5e>] driver_probe_device+0x3c/0x118
> [<00000000a7874938>] __device_attach_driver+0xb8/0xf8
> [<0000000065319e69>] bus_for_each_drv+0x84/0xe4
> [<00000000db3eb243>] __device_attach+0xfc/0x18c
> [<0000000072e4e1a4>] device_initial_probe+0x14/0x20
>
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
> ---
> drivers/remoteproc/imx_rproc.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 74299af1d7f1..c489bd15ee91 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -595,6 +595,19 @@ static int imx_rproc_prepare(struct rproc *rproc)
> return 0;
> }
>
> +static int imx_rproc_unprepare(struct rproc *rproc)
> +{
> + struct rproc_mem_entry *entry, *tmp;
> +
> + rproc_coredump_cleanup(rproc);
> + /* clean up carveout allocations */
> + list_for_each_entry_safe(entry, tmp, &rproc->carveouts, node) {
> + list_del(&entry->node);
> + kfree(entry);
> + }
> + return 0;
> +}
> +
> static int imx_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw)
> {
> int ret;
> @@ -675,6 +688,7 @@ imx_rproc_elf_find_loaded_rsc_table(struct rproc *rproc, const struct firmware *
>
> static const struct rproc_ops imx_rproc_ops = {
> .prepare = imx_rproc_prepare,
> + .unprepare = imx_rproc_unprepare,
> .attach = imx_rproc_attach,
> .detach = imx_rproc_detach,
> .start = imx_rproc_start,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] remoteproc: imx_rproc: release carveout under imx_rproc after rproc_attach() fails
2025-04-25 16:47 ` [PATCH 1/2] remoteproc: imx_rproc: release carveout under imx_rproc " Mathieu Poirier
@ 2025-04-26 0:07 ` xiaolei wang
0 siblings, 0 replies; 4+ messages in thread
From: xiaolei wang @ 2025-04-26 0:07 UTC (permalink / raw)
To: Mathieu Poirier
Cc: andersson, shawnguo, festevam, kernel, linux-remoteproc,
linux-arm-kernel, imx, linux-kernel
On 4/26/25 00:47, Mathieu Poirier wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Thu, Apr 24, 2025 at 08:22:51PM +0800, Xiaolei Wang wrote:
>> Release all carveouts under imx_rproc after rproc_attach() fails to solve
>> the following kmemleak:
>>
> Please provide more details on the steps needed to reproduce this problem and
> where in rproc_attach() the original failure occured.
Thanks for your reply, I will add the steps to reproduce and where in
rproc_attach() the original failure occurred and send a v2 version
thanks
xiaolei
>
> Thanks,
> Mathieu
>
>> unreferenced object 0xffff0000861c5d00 (size 128):
>> comm "kworker/u12:3", pid 59, jiffies 4294893509 (age 149.220s)
>> hex dump (first 32 bytes):
>> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>> 00 00 02 88 00 00 00 00 00 00 10 00 00 00 00 00 ............
>> backtrace:
>> [<00000000f949fe18>] slab_post_alloc_hook+0x98/0x37c
>> [<00000000adbfb3e7>] __kmem_cache_alloc_node+0x138/0x2e0
>> [<00000000521c0345>] kmalloc_trace+0x40/0x158
>> [<000000004e330a49>] rproc_mem_entry_init+0x60/0xf8
>> [<000000002815755e>] imx_rproc_prepare+0xe0/0x180
>> [<0000000003f61b4e>] rproc_boot+0x2ec/0x528
>> [<00000000e7e994ac>] rproc_add+0x124/0x17c
>> [<0000000048594076>] imx_rproc_probe+0x4ec/0x5d4
>> [<00000000efc298a1>] platform_probe+0x68/0xd8
>> [<00000000110be6fe>] really_probe+0x110/0x27c
>> [<00000000e245c0ae>] __driver_probe_device+0x78/0x12c
>> [<00000000f61f6f5e>] driver_probe_device+0x3c/0x118
>> [<00000000a7874938>] __device_attach_driver+0xb8/0xf8
>> [<0000000065319e69>] bus_for_each_drv+0x84/0xe4
>> [<00000000db3eb243>] __device_attach+0xfc/0x18c
>> [<0000000072e4e1a4>] device_initial_probe+0x14/0x20
>>
>> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
>> ---
>> drivers/remoteproc/imx_rproc.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
>> index 74299af1d7f1..c489bd15ee91 100644
>> --- a/drivers/remoteproc/imx_rproc.c
>> +++ b/drivers/remoteproc/imx_rproc.c
>> @@ -595,6 +595,19 @@ static int imx_rproc_prepare(struct rproc *rproc)
>> return 0;
>> }
>>
>> +static int imx_rproc_unprepare(struct rproc *rproc)
>> +{
>> + struct rproc_mem_entry *entry, *tmp;
>> +
>> + rproc_coredump_cleanup(rproc);
>> + /* clean up carveout allocations */
>> + list_for_each_entry_safe(entry, tmp, &rproc->carveouts, node) {
>> + list_del(&entry->node);
>> + kfree(entry);
>> + }
>> + return 0;
>> +}
>> +
>> static int imx_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw)
>> {
>> int ret;
>> @@ -675,6 +688,7 @@ imx_rproc_elf_find_loaded_rsc_table(struct rproc *rproc, const struct firmware *
>>
>> static const struct rproc_ops imx_rproc_ops = {
>> .prepare = imx_rproc_prepare,
>> + .unprepare = imx_rproc_unprepare,
>> .attach = imx_rproc_attach,
>> .detach = imx_rproc_detach,
>> .start = imx_rproc_start,
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-26 0:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-24 12:22 [PATCH 1/2] remoteproc: imx_rproc: release carveout under imx_rproc after rproc_attach() fails Xiaolei Wang
2025-04-24 12:22 ` [PATCH 2/2] remoteproc: core: release rproc->clean_table " Xiaolei Wang
2025-04-25 16:47 ` [PATCH 1/2] remoteproc: imx_rproc: release carveout under imx_rproc " Mathieu Poirier
2025-04-26 0:07 ` xiaolei wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).