* [PATCH v1] arm64: dts: imx8qm: add ethernet aliases
@ 2025-04-22 10:02 Francesco Dolcini
2025-04-25 13:44 ` Oliver Graute
2025-04-25 16:36 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Francesco Dolcini @ 2025-04-22 10:02 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel
From: Francesco Dolcini <francesco.dolcini@toradex.com>
Add ethernet aliases, they are used by the firmware to set the MAC
address and by systemd to rename network interfaces to predictable
interface names, e.g. end0 and end1.
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
arch/arm64/boot/dts/freescale/imx8qm.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
index 6fa31bc9ece8..eccd0087efa7 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
@@ -17,6 +17,8 @@ / {
#size-cells = <2>;
aliases {
+ ethernet0 = &fec1;
+ ethernet1 = &fec2;
mmc0 = &usdhc1;
mmc1 = &usdhc2;
mmc2 = &usdhc3;
--
2.39.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1] arm64: dts: imx8qm: add ethernet aliases
2025-04-22 10:02 [PATCH v1] arm64: dts: imx8qm: add ethernet aliases Francesco Dolcini
@ 2025-04-25 13:44 ` Oliver Graute
2025-04-25 16:36 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Oliver Graute @ 2025-04-25 13:44 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel
On 22/04/25, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> Add ethernet aliases, they are used by the firmware to set the MAC
> address and by systemd to rename network interfaces to predictable
> interface names, e.g. end0 and end1.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Acked-by: Oliver Graute <oliver.graute@kococonnector.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] arm64: dts: imx8qm: add ethernet aliases
2025-04-22 10:02 [PATCH v1] arm64: dts: imx8qm: add ethernet aliases Francesco Dolcini
2025-04-25 13:44 ` Oliver Graute
@ 2025-04-25 16:36 ` Krzysztof Kozlowski
2025-04-25 16:39 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-25 16:36 UTC (permalink / raw)
To: Francesco Dolcini, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel
On 22/04/2025 12:02, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> Add ethernet aliases, they are used by the firmware to set the MAC
> address and by systemd to rename network interfaces to predictable
> interface names, e.g. end0 and end1.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> arch/arm64/boot/dts/freescale/imx8qm.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> index 6fa31bc9ece8..eccd0087efa7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> @@ -17,6 +17,8 @@ / {
> #size-cells = <2>;
>
> aliases {
> + ethernet0 = &fec1;
> + ethernet1 = &fec2;
Can't they be disabled (e.g. because MAC is external?) on actual board?
IOW, aliases for exposed interfaces are properties of boards, not SoC.
What's more, I cannot find these in this DTSI, so how can you add alias
to non-existing node?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] arm64: dts: imx8qm: add ethernet aliases
2025-04-25 16:36 ` Krzysztof Kozlowski
@ 2025-04-25 16:39 ` Krzysztof Kozlowski
2025-04-25 19:22 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-25 16:39 UTC (permalink / raw)
To: Francesco Dolcini, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel
On 25/04/2025 18:36, Krzysztof Kozlowski wrote:
> On 22/04/2025 12:02, Francesco Dolcini wrote:
>> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>>
>> Add ethernet aliases, they are used by the firmware to set the MAC
>> address and by systemd to rename network interfaces to predictable
>> interface names, e.g. end0 and end1.
>>
>> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
>> ---
>> arch/arm64/boot/dts/freescale/imx8qm.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>> index 6fa31bc9ece8..eccd0087efa7 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>> @@ -17,6 +17,8 @@ / {
>> #size-cells = <2>;
>>
>> aliases {
>> + ethernet0 = &fec1;
>> + ethernet1 = &fec2;
> Can't they be disabled (e.g. because MAC is external?) on actual board?
> IOW, aliases for exposed interfaces are properties of boards, not SoC.
>
> What's more, I cannot find these in this DTSI, so how can you add alias
> to non-existing node?
I found them (terrible design by NXP) but they are disabled so that's
the point - adding aliases to disabled nodes is clear sign you are doing
it wrong.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] arm64: dts: imx8qm: add ethernet aliases
2025-04-25 16:39 ` Krzysztof Kozlowski
@ 2025-04-25 19:22 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-25 19:22 UTC (permalink / raw)
To: Francesco Dolcini, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Francesco Dolcini, devicetree, imx, linux-arm-kernel,
linux-kernel
On 25/04/2025 18:39, Krzysztof Kozlowski wrote:
> On 25/04/2025 18:36, Krzysztof Kozlowski wrote:
>> On 22/04/2025 12:02, Francesco Dolcini wrote:
>>> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>>>
>>> Add ethernet aliases, they are used by the firmware to set the MAC
>>> address and by systemd to rename network interfaces to predictable
>>> interface names, e.g. end0 and end1.
>>>
>>> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
>>> ---
>>> arch/arm64/boot/dts/freescale/imx8qm.dtsi | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>>> index 6fa31bc9ece8..eccd0087efa7 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>>> @@ -17,6 +17,8 @@ / {
>>> #size-cells = <2>;
>>>
>>> aliases {
>>> + ethernet0 = &fec1;
>>> + ethernet1 = &fec2;
>> Can't they be disabled (e.g. because MAC is external?) on actual board?
>> IOW, aliases for exposed interfaces are properties of boards, not SoC.
>>
>> What's more, I cannot find these in this DTSI, so how can you add alias
>> to non-existing node?
>
> I found them (terrible design by NXP) but they are disabled so that's
> the point - adding aliases to disabled nodes is clear sign you are doing
> it wrong.
I'll fix existing NXP boards because this pattern of adding aliases for
disabled (thus non-existing) interface is in multiple places.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-04-25 19:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-22 10:02 [PATCH v1] arm64: dts: imx8qm: add ethernet aliases Francesco Dolcini
2025-04-25 13:44 ` Oliver Graute
2025-04-25 16:36 ` Krzysztof Kozlowski
2025-04-25 16:39 ` Krzysztof Kozlowski
2025-04-25 19:22 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).