From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FF8EC3ABC3 for ; Fri, 9 May 2025 08:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NayRbH+Za6jxrlNZRjNmkKSqs2Xv5DXjaUGWLMkJCjA=; b=vVJCe3FruqKFYjATpBYppA3+Gg jttXfk/4tEYnqNwO8BA3N/oMQeGs+tghkx22m+iHD0HUmZGT3sfpkbGug3NkNFlafqs2fY6+AdW2g dcarQbiGNEwOF3a2qrBOfPGH4VCCZlvlSXwkrNSP39+d3VRvUHkGVckq/1ZF9V+qVk7jRTySd78Sq YOHBg42VLDyvOpgYOKpdvbPR6CUmOrkGRh+Iij4Zp0RRsmTV7YphRY5zQjjYjcLnAoeQXMy1ZSps6 XaBx377V1GSch2YdmNlv9QENStp69+ZCHxge84QchDW2YgJtkt/8zogzQX8IKTtXHxHYluyRcHzpM LcITUt7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uDJY8-000000030YE-0AHH; Fri, 09 May 2025 08:57:44 +0000 Received: from mail-m16.yeah.net ([1.95.21.16]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uDIkd-00000002rf2-2O35 for linux-arm-kernel@lists.infradead.org; Fri, 09 May 2025 08:06:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:To:Subject:Message-ID:MIME-Version: Content-Type; bh=NayRbH+Za6jxrlNZRjNmkKSqs2Xv5DXjaUGWLMkJCjA=; b=YlaJVlDDmaVnGqHNZVFamQwncF6km7Bx+FItRKfR6TspwW098A0Gi/STDfSGNh 53Jc+stXuN+KoneyrNrCEGUJYaSHct5O1gKM4V/8paX/mrQQK8FptEj0dGhKgrMk IhxHMPaESFJinRDI0mdIYQLMs87pgjUJ5lC4zD6SpatFs= Received: from dragon (unknown []) by gzsmtp1 (Coremail) with SMTP id Mc8vCgAnPuNhtx1ojC+mAA--.27459S3; Fri, 09 May 2025 16:05:55 +0800 (CST) Date: Fri, 9 May 2025 16:05:52 +0800 From: Shawn Guo To: maudspierings@gocontroll.com Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Frank Li Subject: Re: [PATCH v6 2/8] arm64: dts: imx8mp: Add pinctrl config definitions Message-ID: References: <20250417-initial_display-v6-0-3c6f6d24c7af@gocontroll.com> <20250417-initial_display-v6-2-3c6f6d24c7af@gocontroll.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250417-initial_display-v6-2-3c6f6d24c7af@gocontroll.com> X-CM-TRANSID: Mc8vCgAnPuNhtx1ojC+mAA--.27459S3 X-Coremail-Antispam: 1Uf129KBjvJXoWxAFW5XF1kWrWrGryUuF45ZFb_yoW5Gw43pF yqkry3Zr18tF47Gw1Sv3Wayrs0v3Z3XF47u3y7WrW5tF4DAw18XF1Ygw4Ygr1Yqrsag3yF 9F1qvw1I93sxGrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jeE__UUUUU= X-Originating-IP: [117.81.80.76] X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiEgVIZWgdtb4IEAAAsc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250509_010635_966250_5D595777 X-CRM114-Status: GOOD ( 19.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 17, 2025 at 12:14:03PM +0200, Maud Spierings via B4 Relay wrote: > From: Maud Spierings > > Currently to configure each IOMUXC_SW_PAD_CTL_PAD the raw value of this > register is written in the dts, these values are not obvious. Add defines > which describe the fields of this register which can be or-ed together to > produce readable settings. > > Reviewed-by: Frank Li > Acked-by: Rob Herring (Arm) > Signed-off-by: Maud Spierings > --- > This patch has already been sent in a different group of patches: [1] > It was requested there to submit it along with a user, this series also > includes some users for it. > > [1]: https://lore.kernel.org/all/20250218-pinctrl_defines-v2-2-c554cad0e1d2@gocontroll.com/ > --- > arch/arm64/boot/dts/freescale/imx8mp-pinfunc.h | 33 ++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-pinfunc.h b/arch/arm64/boot/dts/freescale/imx8mp-pinfunc.h > index 0fef066471ba607be02d0ab15da5a048a8a213a7..19a23d148246f4fb990050a9d06d20b6e769f254 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-pinfunc.h > +++ b/arch/arm64/boot/dts/freescale/imx8mp-pinfunc.h > @@ -6,6 +6,39 @@ > #ifndef __DTS_IMX8MP_PINFUNC_H > #define __DTS_IMX8MP_PINFUNC_H > > +/* Drive Strength */ > +#define MX8MP_DSE_X1 0x0 > +#define MX8MP_DSE_X2 0x4 > +#define MX8MP_DSE_X4 0x2 > +#define MX8MP_DSE_X6 0x6 > + > +/* Slew Rate */ > +#define MX8MP_FSEL_FAST 0x10 > +#define MX8MP_FSEL_SLOW 0x0 > + > +/* Open Drain */ > +#define MX8MP_ODE_ENABLE 0x20 > +#define MX8MP_ODE_DISABLE 0x0 > + > +#define MX8MP_PULL_DOWN 0x0 > +#define MX8MP_PULL_UP 0x40 > + > +/* Hysteresis */ > +#define MX8MP_HYS_CMOS 0x0 > +#define MX8MP_HYS_SCHMITT 0x80 > + > +#define MX8MP_PULL_ENABLE 0x100 > +#define MX8MP_PULL_DISABLE 0x0 > + > +/* SION force input mode */ > +#define MX8MP_SION 0x40000000 Can we have all these indents aligned on the same column using tabs? > + > +/* long defaults */ > +#define MX8MP_USDHC_DATA_DEFAULT (MX8MP_FSEL_FAST | MX8MP_PULL_UP | \ > + MX8MP_HYS_SCHMITT | MX8MP_PULL_ENABLE) Can we indent like this? #define MX8MP_USDHC_DATA_DEFAULT (MX8MP_FSEL_FAST | MX8MP_PULL_UP | \ MX8MP_HYS_SCHMITT | MX8MP_PULL_ENABLE) Shawn > +#define MX8MP_I2C_DEFAULT (MX8MP_DSE_X6 | MX8MP_PULL_UP | MX8MP_HYS_SCHMITT | \ > + MX8MP_PULL_ENABLE | MX8MP_SION) > + > /* > * The pin function ID is a tuple of > * > > -- > 2.49.0 > >