Re: [PATCH v2 2/5] dt-bindings: phy: rockchip: naneng-combphy: Add RK3528 variant

[Yao Zi <ziyao@disroot.org>]

On Fri, May 09, 2025 at 08:03:11AM +0200, Krzysztof Kozlowski wrote:
> On Fri, May 09, 2025 at 12:41:19AM GMT, Yao Zi wrote:
> > Rockchip RK3528 ships one naneng-combphy which operates in either PCIe
> > or USB 3 mode. Document its compatible string.
> > 
> > Signed-off-by: Yao Zi <ziyao@disroot.org>
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> 
> Eh, no...
> 
> >  .../devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> > index 888e6b2aac5a..bd064754e537 100644
> > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> > @@ -12,6 +12,7 @@ maintainers:
> >  properties:
> >    compatible:
> >      enum:
> > +      - rockchip,rk3528-naneng-combphy
> >        - rockchip,rk3562-naneng-combphy
> >        - rockchip,rk3568-naneng-combphy
> >        - rockchip,rk3576-naneng-combphy
> > @@ -102,7 +103,9 @@ allOf:
> >        properties:
> >          compatible:
> >            contains:
> > -            const: rockchip,rk3588-naneng-combphy
> > +            enum:
> > +             - rockchip,rk3528-naneng-combphy
> 
> Still not tested. Neither v1 nor v2 was ever tested.

Oops, somehow I missed warnings about the indentation...

Thanks for pointing out, I'll drop the tags, wait until the prerequsite
series get merged and send v3 with this problem fixed.

> Best regards,
> Krzysztof
> 

Thanks,
Yao Zi