* [PATCH] arm64: dts: imx8mp: use 800MHz NoC OPP for nominal drive mode
@ 2025-04-22 7:12 Ahmad Fatoum
2025-05-09 9:56 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-04-22 7:12 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Pengutronix Kernel Team, imx, linux-arm-kernel, Fabio Estevam,
Ahmad Fatoum, Peng Fan, devicetree, linux-kernel
When running in nominal drive mode, the maximum allowed frequency for
the NoC is 800MHz, but the OPP table for the i.MX8MP interconnect device
listed the 1GHz operating point for the NoC, regardless of the active
mode.
The newly introduced imx8mp-nominal.dtsi header reconfigures the clock
controller to observe nominal drive mode limits, so have it modify the
maximum NoC OPP as well.
Fixes: 255fbd9eabe7 ("arm64: dts: imx8mp: Add optional nominal drive mode DTSI")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Support for &{label/node} syntax was first vendored into Linux with
v6.2. It's useful here to avoid one-off labels while still ensuring
that a compile error results when the original node disappears.
---
arch/arm64/boot/dts/freescale/imx8mp-nominal.dtsi | 2 ++
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 ++++++
2 files changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-nominal.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-nominal.dtsi
index a1b75c9068b288a2fba73bbd96b1519a50df85a3..115a6da08643bc1b23731c146df9c9dc36b4e85c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-nominal.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-nominal.dtsi
@@ -62,3 +62,5 @@ &media_blk_ctrl {
<0>, <0>, <400000000>,
<1039500000>;
};
+
+/delete-node/ &{noc_opp_table/opp-1000000000};
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index ce6793b2d57eef9489645f498a89f4bd8f3388d5..7c1c87eab54cc632643f206bd80ce7b7b49505de 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -1645,6 +1645,12 @@ opp-200000000 {
opp-hz = /bits/ 64 <200000000>;
};
+ /* Nominal drive mode maximum */
+ opp-800000000 {
+ opp-hz = /bits/ 64 <800000000>;
+ };
+
+ /* Overdrive mode maximum */
opp-1000000000 {
opp-hz = /bits/ 64 <1000000000>;
};
---
base-commit: 8ffd015db85fea3e15a77027fda6c02ced4d2444
change-id: 20250422-imx8m-nominal-noc-8e1db5029574
Best regards,
--
Ahmad Fatoum <a.fatoum@pengutronix.de>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp: use 800MHz NoC OPP for nominal drive mode
2025-04-22 7:12 [PATCH] arm64: dts: imx8mp: use 800MHz NoC OPP for nominal drive mode Ahmad Fatoum
@ 2025-05-09 9:56 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2025-05-09 9:56 UTC (permalink / raw)
To: Ahmad Fatoum
Cc: Shawn Guo, Sascha Hauer, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Pengutronix Kernel Team, imx, linux-arm-kernel,
Fabio Estevam, Peng Fan, devicetree, linux-kernel
On Tue, Apr 22, 2025 at 09:12:35AM +0200, Ahmad Fatoum wrote:
> When running in nominal drive mode, the maximum allowed frequency for
> the NoC is 800MHz, but the OPP table for the i.MX8MP interconnect device
> listed the 1GHz operating point for the NoC, regardless of the active
> mode.
>
> The newly introduced imx8mp-nominal.dtsi header reconfigures the clock
> controller to observe nominal drive mode limits, so have it modify the
> maximum NoC OPP as well.
>
> Fixes: 255fbd9eabe7 ("arm64: dts: imx8mp: Add optional nominal drive mode DTSI")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-09 10:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-22 7:12 [PATCH] arm64: dts: imx8mp: use 800MHz NoC OPP for nominal drive mode Ahmad Fatoum
2025-05-09 9:56 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).