Re: [PATCH] dt-bindings: timer: Convert arm,mps2-timer to DT schema

[Liviu Dudau <liviu.dudau@arm.com>]

On Mon, May 05, 2025 at 09:22:09PM -0500, Rob Herring (Arm) wrote:
> Convert the Arm MPS2 Timer binding to DT schema format. It's a
> straight-forward conversion.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>

Best regards,
Liviu

> ---
>  .../bindings/timer/arm,mps2-timer.txt         | 28 -----------
>  .../bindings/timer/arm,mps2-timer.yaml        | 49 +++++++++++++++++++
>  2 files changed, 49 insertions(+), 28 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/timer/arm,mps2-timer.txt
>  create mode 100644 Documentation/devicetree/bindings/timer/arm,mps2-timer.yaml
> 
> diff --git a/Documentation/devicetree/bindings/timer/arm,mps2-timer.txt b/Documentation/devicetree/bindings/timer/arm,mps2-timer.txt
> deleted file mode 100644
> index 48f84d74edde..000000000000
> --- a/Documentation/devicetree/bindings/timer/arm,mps2-timer.txt
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -ARM MPS2 timer
> -
> -The MPS2 platform has simple general-purpose 32 bits timers.
> -
> -Required properties:
> -- compatible	: Should be "arm,mps2-timer"
> -- reg		: Address and length of the register set
> -- interrupts	: Reference to the timer interrupt
> -
> -Required clocking property, have to be one of:
> -- clocks	  : The input clock of the timer
> -- clock-frequency : The rate in HZ in input of the ARM MPS2 timer
> -
> -Examples:
> -
> -timer1: mps2-timer@40000000 {
> -	compatible = "arm,mps2-timer";
> -	reg = <0x40000000 0x1000>;
> -	interrupts = <8>;
> -	clocks = <&sysclk>;
> -};
> -
> -timer2: mps2-timer@40001000 {
> -	compatible = "arm,mps2-timer";
> -	reg = <0x40001000 0x1000>;
> -	interrupts = <9>;
> -	clock-frequency = <25000000>;
> -};
> diff --git a/Documentation/devicetree/bindings/timer/arm,mps2-timer.yaml b/Documentation/devicetree/bindings/timer/arm,mps2-timer.yaml
> new file mode 100644
> index 000000000000..64c6aedd7e8e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/arm,mps2-timer.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm,mps2-timer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARM MPS2 timer
> +
> +maintainers:
> +  - Vladimir Murzin <vladimir.murzin@arm.com>
> +
> +description:
> +  The MPS2 platform has simple general-purpose 32 bits timers.
> +
> +properties:
> +  compatible:
> +    const: arm,mps2-timer
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-frequency:
> +    description: Rate in Hz of the timer input clock
> +
> +oneOf:
> +  - required: [clocks]
> +  - required: [clock-frequency]
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    timer@40000000 {
> +        compatible = "arm,mps2-timer";
> +        reg = <0x40000000 0x1000>;
> +        interrupts = <8>;
> +        clocks = <&sysclk>;
> +    };
> -- 
> 2.47.2
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯