From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA0EDC3ABBF for ; Wed, 7 May 2025 02:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:Date:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Pi47gK8MYhyGIqIdKO9+ShtObSRr4S3t2PvkIQxuaXA=; b=tyBuDrjZD8X7MW7SMQxlj5GIS8 2tmRgZDHouy+0Web+Q/CZXivavD50044OWRmiB8G0RtK4EGMn3PJ+ZCbvCrU/aYdo69HVevACjKN9 gDokWP9MDL1YzWCNZAhbFzZ/KidXbYMysIJ+qxPqwMhzTvZ3tWZaB8AIZvT2VnzaTVWBU39ewg21p o+ioCy3Pagu5Axs6WbTNAzW/bcWFon5wA32xky0SXWCWnpKPr6X3gjE5WldcuE3C+nQpz/OwZWC/L 2tKLFi3yDsPeALckoO8DyVkDojI+t79FypY48KUEYBNrJCiiMtTd/OMQuc4BPNhbdHIsl1qXeDMBm Xo0xBZnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uCUau-0000000Dv5A-2Rwr; Wed, 07 May 2025 02:33:12 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uCPCW-0000000DNcr-490I for linux-arm-kernel@lists.infradead.org; Tue, 06 May 2025 20:47:42 +0000 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-ac2aeada833so60497666b.0 for ; Tue, 06 May 2025 13:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1746564459; x=1747169259; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=Pi47gK8MYhyGIqIdKO9+ShtObSRr4S3t2PvkIQxuaXA=; b=LH+BeVfexEwPiA7JNmaygkza61I6+8FiVak9hkX18Xp2Ps5MimLpXp82W1OgE5l0EF IgjLGgpIPFlR5d2JYtltxVKNY3PNSXXk3OukRRfpcRi8c57FkzP8emtasdixR5DTEWTl ZuK8DdUsZDv0jV1F+FFBo07xqeDaGAZjqsDHOHKhJp76UWaMdcJMzN3iJlfC8rtuj1kX 2zutKvDmuAmbqFsIEn2mbZJJUsXNvt7wwFPj3cOeMXjdn5Q8fSfN1xwfu/JTDsFhXP6S X0kIfHpQN9tkNCK+WmGJ48SsVaPJt83PFeuF4F8l7KS9CpecAGnpZH2xK0WdDWSa3gMW XMQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746564459; x=1747169259; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pi47gK8MYhyGIqIdKO9+ShtObSRr4S3t2PvkIQxuaXA=; b=kDaQtLSZFviFwa5A2HHrRniizNPEkKqp/WungZBeeH49CQcRfU5fVBEII8cKdrTH9M pmLstR3wreWb1g7URMqhXRWm28aYpVXPOJ5aN8B0LxH9twIEbq5T1qa9xz07GfYT8ofC wuq07FVsaORPxaDoCX/ipf7AJtwpf/rdkGVFEOf0lnLhqTeaI5d086eyKlO4841QKIN+ 3LN4+TmKFyfbvR6C5fjSMcz/EpSmMZnAjGGYJs9InwN6huC3TnihJR4LeeuemHORpnUq JGsJBRAFP4hJjZgDYETE/WiXd4e9DYwi70E3M7E83ZCym+gr4h3bF87FlMdOlZN1WP09 rTFA== X-Forwarded-Encrypted: i=1; AJvYcCVmFNA6u8rhnBO/FY2cktujMvKM6RBPkaSooUjcOLG7tmWcnZH5Kt0nKShzT2oNA9OaZYCwHEYaM1POpJKcWx+2@lists.infradead.org X-Gm-Message-State: AOJu0YwoTKMP+5UNZ7noojtG5Ih4UUcyK09CaEYCZNwL4PIjvduR9XvQ LfdBjdC8SsqTuSiNnYQU/CquGJlE3W5M3E7yTDSP7VgDg5z/14OQr0fH49NeynE= X-Gm-Gg: ASbGnctDucgGMN5Ml4l9dwqoPjKerHWbrvPJCNPXyOFBPkoFvDlvO+lGUuUM9S6rrsQ SR0+fSRvw582wK4U8s2G+zlFIAeHLTwaVobiAUnQuReQAyFp38TAieyvqJyPW8E/WpclLSGjwqx +PXNG4eLXzh4G6StJR6s9NxtASgNJQnV5tfwAV6zBFqhiipPbxHlBK2XXYHGHjq67VarUOn+5Xg N1Zii9gP+k/GWEEsPZ9zlg1lC2Ji/A2QU7BywTMA2D7FoaT75kQfPasFklsnO8hSQqvixOgfPqg +9UCQWWjpAa51S6Oso+I8rp/QfCgtjIP9VC/CpuiXBCXwvULhKYZ2NGA/WhqkrVD1xQjv4U= X-Google-Smtp-Source: AGHT+IGdejKWhHgobANcBR0HkA6BZ7303l9tnuRyiuAvIspM7E6yB+9PaEvl5m9+eOZo13IwvIZIoA== X-Received: by 2002:a17:907:6d23:b0:ac7:3929:25fa with SMTP id a640c23a62f3a-ad1e79a28bamr109364566b.30.1746564459254; Tue, 06 May 2025 13:47:39 -0700 (PDT) Received: from localhost (93-44-188-26.ip98.fastwebnet.it. [93.44.188.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad189540d5bsm770703266b.176.2025.05.06.13.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 13:47:38 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Tue, 6 May 2025 22:49:07 +0200 To: Andrea della Porta Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn , Phil Elwell , Dave Stevenson , kernel-list@raspberrypi.com, Matthias Brugger Subject: Re: [PATCH v9 -next 08/12] arm64: dts: bcm2712: Add external clock for RP1 chipset on Rpi5 Message-ID: References: <38514415df9c174be49e72b88410d56c8de586c5.1745347417.git.andrea.porta@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38514415df9c174be49e72b88410d56c8de586c5.1745347417.git.andrea.porta@suse.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250506_134741_026002_5B249BD8 X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Florian, On 20:53 Tue 22 Apr , Andrea della Porta wrote: > The RP1 found on Raspberry Pi 5 board needs an external crystal at 50MHz. > Add clk_rp1_xosc node to provide that. > > Signed-off-by: Andrea della Porta > Reviewed-by: Florian Fainelli A gentle reminder for patches 8 through 12 of this series, which I guess would ideally be taken by you. Since the merge window is approaching, do you think it's feasible to iterate a second pull request to Arnd with my patches too? With respect to your devicetree/next branch, my patches have the following conflicts: PATCH 9: - arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts: &pcie1 and &pcie2 reference at the end, my patch was rebased on linux-next which has them while your devicetree branch has not. This is trivial to fix too. PATCH 9 and 10: - arch/arm64/boot/dts/broadcom/Makefile on your branch has a line recently added by Stefan's latest patch for RPi2. The fix is trivial. PATCH 11 and 12: - arch/arm64/configs/defconfig: just a couple of fuzz lines. Please let me know if I should resend those patches adjusted for your tree. Many thanks, Andrea > --- > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > index 34470e3d7171..6ea3c102e0d6 100644 > --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > @@ -16,6 +16,13 @@ chosen: chosen { > stdout-path = "serial10:115200n8"; > }; > > + clk_rp1_xosc: clock-50000000 { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-output-names = "rp1-xosc"; > + clock-frequency = <50000000>; > + }; > + > /* Will be filled by the bootloader */ > memory@0 { > device_type = "memory"; > -- > 2.35.3 >