From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC77FC54E65 for ; Thu, 22 May 2025 16:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r6q6oH3X3gQx3mAEHti6FuXtaZ61BsgoYbZipAoFrvE=; b=1bQpQ2JEzRgTKTNyGw2RZAPhrO ChbT3L9qaiLVt4l82CqIj2usH2V+v7WetDfIOzbu5KNFByBxM8B2OFwsWNjXs/ghiaKgk1N8nZfcY BOD2g4FqxVZx84wEOT0MV8Pna9BrNCyJfqDAVWuhuvcKj18TqTdDgqqM4X5iOX/i9MxV6g4njmnDp KtxVGI9yK6wv6K/df/fc4ivWRrKxq8cTKJRcog5IPcD0a1UJQZeVoj/GnSfYw/5ycMzm8lJgOAXJC UD0dZJ/uYgEU4D4/C03iiO0U24mRHqQvCp44a8nREM/SkqgFHpwyBRskI0lNRy9sFZ4ozOO3fFIyQ cAQapWKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uI8m6-00000001ZGK-0GZl; Thu, 22 May 2025 16:28:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uI8Zi-00000001Xs5-1Jfm for linux-arm-kernel@lists.infradead.org; Thu, 22 May 2025 16:15:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 312CA1A2D; Thu, 22 May 2025 09:14:56 -0700 (PDT) Received: from e133380.arm.com (e133380.arm.com [10.1.197.52]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D9E8D3F5A1; Thu, 22 May 2025 09:15:07 -0700 (PDT) Date: Thu, 22 May 2025 17:15:02 +0100 From: Dave Martin To: "Rob Herring (Arm)" Cc: Will Deacon , Mark Rutland , Catalin Marinas , Jonathan Corbet , Marc Zyngier , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , James Clark , Anshuman Khandual , Leo Yan , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v22 2/5] arm64: el2_setup.h: Make __init_el2_fgt labels consistent, again Message-ID: References: <20250520-arm-brbe-v19-v22-0-c1ddde38e7f8@kernel.org> <20250520-arm-brbe-v19-v22-2-c1ddde38e7f8@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250520-arm-brbe-v19-v22-2-c1ddde38e7f8@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250522_091518_397665_0334B742 X-CRM114-Status: GOOD ( 20.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 20, 2025 at 05:27:37PM -0500, Rob Herring (Arm) wrote: > From: Anshuman Khandual > > Commit 5b39db6037e7 ("arm64: el2_setup.h: Rename some labels to be more > diff-friendly") reworked the labels in __init_el2_fgt to say what's > skipped rather than what the target location is. The exception was > "set_fgt_" which is where registers are written. In reviewing the BRBE > additions, Will suggested "set_debug_fgt_" where HDFGxTR_EL2 are > written. Doing that would partially revert commit 5b39db6037e7 undoing > the goal of minimizing additions here, but it would follow the > convention for labels where registers are written. > > So let's do both. Branches that skip something go to a "skip" label and > places that set registers have a "set" label. This results in some > double labels, but it makes things entirely consistent. > > While we're here, the SME skip label was incorrectly named, so fix it. > > Reported-by: Will Deacon > Cc: Dave Martin > Signed-off-by: Rob Herring (Arm) > --- > This one can be applied even if the rest of the series is not. > > v22: > - New patch > --- > arch/arm64/include/asm/el2_setup.h | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/include/asm/el2_setup.h b/arch/arm64/include/asm/el2_setup.h > index ebceaae3c749..30f57b0334a3 100644 > --- a/arch/arm64/include/asm/el2_setup.h > +++ b/arch/arm64/include/asm/el2_setup.h > @@ -204,19 +204,21 @@ > orr x0, x0, #(1 << 62) > > .Lskip_spe_fgt_\@: > + > +.Lset_debug_fgt_\@: Dangling label? There doesn't seem to be any branch to it in this series, unless I've missed something. [...] Cheers ---Dave