From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E112CC3ABBC for ; Mon, 12 May 2025 06:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v5/rC4hc4BHqaRiqWpaNZwbcjvpWnFmSMM3dC4ytv68=; b=ClkXmIzmEXf1mzcE7P1EUjGNZi DN4feweJMlBtFG0y4l1AVxqFzyx8uzY0ncXxv8X2FSd48ftMDEUCY27wfg1wcPR1igN4I2ZanYbKd 9DObmYnzqFCCc4JyY0ogaLt5AmyY+C+H+HaiNvH3vcWXkwEvn+htSbib55xAlHhqU+WhZ2/eKFFqj u8/E58UVXGgnuiI/T0tmXTfoVT1mxRuu4QDausvYhdzr92SL1XmDgDX4iPayQT/FUUitlw4OxK4qn avEh6cR5t9XHp1YlqWrXonlklwMEwHr/m0QnpPjo7wgQk7rUn3v2+0bGvtZBjNwtz42FaZkwmhK/8 ujZ8t02A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEMW8-00000008Uaa-2OhC; Mon, 12 May 2025 06:20:00 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEMU4-00000008URF-1jCC for linux-arm-kernel@lists.infradead.org; Mon, 12 May 2025 06:17:54 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uEMTu-0002PJ-UB; Mon, 12 May 2025 08:17:42 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uEMTu-002KAO-0e; Mon, 12 May 2025 08:17:42 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1uEMTu-000RQ1-08; Mon, 12 May 2025 08:17:42 +0200 Date: Mon, 12 May 2025 08:17:42 +0200 From: Sascha Hauer To: "Peng Fan (OSS)" Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Pengutronix Kernel Team , Fabio Estevam , Dong Aisheng , Jacky Bai , NXP S32 Linux Team , Linus Walleij , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan Subject: Re: [PATCH 2/3] pinctrl: imx-scmi: Get daisy register offset from DT Message-ID: References: <20250512-pin-v1-0-d9f1555a55ad@nxp.com> <20250512-pin-v1-2-d9f1555a55ad@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250512-pin-v1-2-d9f1555a55ad@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250511_231753_059178_B0B4306C X-CRM114-Status: GOOD ( 19.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 12, 2025 at 10:14:15AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Parsing the "nxp,iomuxc-daisy-off" to get the daisy register offset, > then no need to hardcode the register offset in driver for new SoCs. > > To keep backwards comatibility, still keep the register offset for i.MX95. > > Signed-off-by: Peng Fan > --- > drivers/pinctrl/freescale/pinctrl-imx-scmi.c | 26 +++++++++++++++----------- > 1 file changed, 15 insertions(+), 11 deletions(-) > > @@ -315,6 +307,18 @@ static int scmi_pinctrl_imx_probe(struct scmi_device *sdev) > if (!pmx) > return -ENOMEM; > > + ret = device_property_read_u32(dev, "nxp,iomuxc-daisy-off", &pmx->daisy_off); "off" is really a poor acronym for "offset" as it unnecessarily confuses the reader by suggesting this is about turning some feature off. Please add the three bytes and just call it offset. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |