From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B7ACC3ABC9 for ; Thu, 15 May 2025 14:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lScQ/JajhnIhsL2NtC93B8khp/OVsF7KF0cOeTMiO1w=; b=gLheCg6+cnXQYBUMGCBM5WtaMK FaFrHX81u8UrPIq9ICVHIU7+8qJplTIPB0WtNrm4/fwf5QNpapySU3A9RgMprZpmoheThzWS7zVhK 6A39xoplt7ZRxkIhSu6gw6b2HhVllaW4P3FPy92niEIDxsJpiaXw4QXStdvJEU00eHsGQLXXWxcnN NBj+9VMDqzbrw8nCwvAFKr+hcyeld5G5w/CUvXXIM+VYtPx6nghffC13cx9iswxDzOoAvY8sBbmMz eowcZS9iYVMW+P84cNBU9EdJ3Sv+StiQIllGg2D4kjiiHbc2JkU3KLliyAdNvrIqodNLRFJeWPXaO btd4ASLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uFZ9b-00000000pHW-1wu3; Thu, 15 May 2025 14:01:43 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uFZ7Z-00000000p54-2CkC for linux-arm-kernel@lists.infradead.org; Thu, 15 May 2025 13:59:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D858C14BF; Thu, 15 May 2025 06:59:22 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4F8C53F673; Thu, 15 May 2025 06:59:32 -0700 (PDT) Date: Thu, 15 May 2025 14:59:24 +0100 From: Cristian Marussi To: long.yunjian@zte.com.cn Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, peng.fan@nxp.com, justin.chen@broadcom.com, florian.fainelli@broadcom.com, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fang.yumeng@zte.com.cn, mou.yi@zte.com.cn, ouyang.maochun@zte.com.cn, xu.lifeng1@zte.com.cn Subject: Re: [PATCH] firmware: arm_scmi: Use dev_err_probe() simplify the code Message-ID: References: <20250515203855146Sn9x-Uw9Teur35mOjn41C@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250515203855146Sn9x-Uw9Teur35mOjn41C@zte.com.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250515_065937_604969_2F5F5F09 X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 15, 2025 at 08:38:55PM +0800, long.yunjian@zte.com.cn wrote: > From: Yumeng Fang > Hi, > In the probe path, dev_err() can be replaced with dev_err_probe() > which will check if error code is -EPROBE_DEFER and prints the > error name. It also sets the defer probe reason which can be > checked later through debugfs. All true...but...if you look at the main scmi_probe() function all of these failures are trapped at that level currently on the return path... see the call chain from scmi_probe() .... ret = scmi_channels_setup(info); ... ...so your probe errors will be overridden there with a more generic message left in debugfs at the top level. Thanks, Cristian