linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: airoha: Add FLOW_CLS_STATS callback support
Date: Fri, 16 May 2025 08:29:28 +0200	[thread overview]
Message-ID: <aCbbSHkBRrm4yM1f@lore-desk> (raw)
In-Reply-To: <20250515181357.73f98a18@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

On May 15, Jakub Kicinski wrote:
> On Wed, 14 May 2025 19:09:58 +0200 Lorenzo Bianconi wrote:
> > Introduce per-flow stats accounting to the flowtable hw offload in
> > the airoha_eth driver. Flow stats are split in the PPE and NPU modules:
> > - PPE: accounts for high 32bit of per-flow stats
> > - NPU: accounts for low 32bit of per-flow stats
> > 
> > FLOW_CLS_STATS can be enabled or disabled at compile time.
> 
> sparse isn't happy:
> 
> drivers/net/ethernet/airoha/airoha_npu.c:382:15: warning: incorrect type in assignment (different address spaces)
> drivers/net/ethernet/airoha/airoha_npu.c:382:15:    expected void *stats
> drivers/net/ethernet/airoha/airoha_npu.c:382:15:    got void [noderef] __iomem *

ack, I will fix it in v2.

Regards,
Lorenzo

> -- 
> pw-bot: cr

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2025-05-16  6:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-14 17:09 [PATCH net-next 0/2] net: airoha: Add per-flow stats support to hw flowtable offloading Lorenzo Bianconi
2025-05-14 17:09 ` [PATCH net-next 1/2] net: airoha: npu: Move memory allocation in airoha_npu_send_msg() caller Lorenzo Bianconi
2025-05-14 17:09 ` [PATCH net-next 2/2] net: airoha: Add FLOW_CLS_STATS callback support Lorenzo Bianconi
2025-05-16  1:13   ` Jakub Kicinski
2025-05-16  6:29     ` Lorenzo Bianconi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCbbSHkBRrm4yM1f@lore-desk \
    --to=lorenzo@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).