Re: [PATCH 2/2] arm64: dts: ls1028a: Add mbls1028a and mbls1028a-ind devicetrees

[Frank Li <Frank.li@nxp.com>]

On Mon, Jun 02, 2025 at 04:28:55PM +0200, Alexander Stein wrote:
> Am Freitag, 30. Mai 2025, 18:17:00 CEST schrieb Frank Li:
> > ********************
> > Achtung externe E-Mail: Öffnen Sie Anhänge und Links nur, wenn Sie wissen, dass diese aus einer sicheren Quelle stammen und sicher sind. Leiten Sie die E-Mail im Zweifelsfall zur Prüfung an den IT-Helpdesk weiter.
> > Attention external email: Open attachments and links only if you know that they are from a secure source and are safe. In doubt forward the email to the IT-Helpdesk to check it.
> > ********************
> >
> > On Fri, May 30, 2025 at 08:29:27AM +0200, Alexander Stein wrote:
> > > Hi Frank,
> > >
> > > Am Mittwoch, 28. Mai 2025, 17:35:52 CEST schrieb Frank Li:
> > > > On Tue, May 27, 2025 at 08:03:55AM +0200, Alexander Stein wrote:
> > > > > From: Gregor Herburger <gregor.herburger@tq-group.com>
> > > > >
> > > > > Add device trees for the MBLS1028A and the MBLS1028A-IND and the SoM
> > > > > TQMLS1028A.
> > > > >
> > > > > Signed-off-by: Gregor Herburger <gregor.herburger@tq-group.com>
> > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > > ---
> > > > >  arch/arm64/boot/dts/freescale/Makefile        |   2 +
> > > > >  .../fsl-ls1028a-tqmls1028a-mbls1028a-ind.dts  |  68 ++++
> > > > >  .../fsl-ls1028a-tqmls1028a-mbls1028a.dts      | 118 +++++++
> > > > >  .../fsl-ls1028a-tqmls1028a-mbls1028a.dtsi     | 291 ++++++++++++++++++
> > > > >  .../dts/freescale/fsl-ls1028a-tqmls1028a.dtsi | 117 +++++++
> > > >
> > > > New dts file, suggest run https://github.com/lznuaa/dt-format to nice order
> > >
> > > Thanks for the suggestions. It does some improvements, but I also disagree
> > > with a lot of proposed changes:
> > > * Wrong indent of SPDX tag
> > > * model property should come first IMHO
> > > * {gpio,interrupt}-controller should come before #{gpio,interrupt}-cells
> >
> > I checked code, it is specific rule to make -cells before -controller. It
> > should come from previous review comments.
> >
> > Do you have document or mail list require -controller before --cells ?
>
> There is Documentation/devicetree/bindings/interrupt-controller/interrupts.txt.
> While not exactly saying anything about property order, "interrupt-controller"
> is stated in the very first sentence.
> Also from a readers perspective having "-controller" first seems
> reasonable, IMHO. "-cells" is necessary because it is a controller.

This document have not updated since 2019.

A rob acked
https://lore.kernel.org/linux-devicetree/20250513-gicv5-host-v4-1-b36e9b15a6c3@kernel.org/

interrupt-cell and msi-cell is before interrupt-controller and
msi-controller.  The order may not be big deal. -cell carry more impantant
informaiton than -controller because all consumer needs know -cell number.

Rob:
  Do you have suggestion about these order, so we can easily follow for new
dts files

Frank

>
> Best regards
> Alexander
>
> > Frank
> >
> > > * gpio-hog property should come first in a hog node
> > > * sorting gpio-hog nodes by name instead of line number seems wrong
> > >
> > > There are some more bogus changes, so I'll skip this tool for now.
> > >
> > > Thanks & best regards
> > > Alexander
> > >
> > > > Frank
> > > > [...]
> > > --
> > > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> > > Amtsgericht München, HRB 105018
> > > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> > > http://www.tq-group.com/
> > >
> > >
> >
> >
>
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
>
>