From: Mark Rutland <mark.rutland@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] kselftest/arm64: Fix test for streaming FPSIMD write in sve-ptrace
Date: Mon, 26 May 2025 11:44:40 +0100 [thread overview]
Message-ID: <aDRGGDgQtlh8sew6@J2N7QTR9R3> (raw)
In-Reply-To: <20250523-kselftest-arm64-ssve-fixups-v1-2-65069a263b21@kernel.org>
On Fri, May 23, 2025 at 04:27:13PM +0100, Mark Brown wrote:
> Since f916dd32a943 ("arm64/fpsimd: ptrace: Mandate SVE payload for
> streaming-mode state") we do not support writing FPSIMD payload data when
> writing NT_ARM_SSVE but the sve-ptrace test has an explicit test for
> this being supported which was not updated to reflect the new behaviour.
> Fix the test to expect a failure when writing FPSIMD data to the
> streaming mode register set.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> tools/testing/selftests/arm64/fp/sve-ptrace.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/arm64/fp/sve-ptrace.c b/tools/testing/selftests/arm64/fp/sve-ptrace.c
> index c499d5789dd5..7e259907805b 100644
> --- a/tools/testing/selftests/arm64/fp/sve-ptrace.c
> +++ b/tools/testing/selftests/arm64/fp/sve-ptrace.c
> @@ -301,8 +301,10 @@ static void ptrace_sve_fpsimd(pid_t child, const struct vec_type *type)
> p[j] = j;
> }
>
> + /* This should only succeed for SVE */
> ret = set_sve(child, type, sve);
> - ksft_test_result(ret == 0, "%s FPSIMD set via SVE: %d\n",
> + ksft_test_result((type->regset == NT_ARM_SVE) == (ret == 0),
> + "%s FPSIMD set via SVE: %d\n",
> type->name, ret);
> if (ret)
> goto out;
>
> --
> 2.39.5
>
next prev parent reply other threads:[~2025-05-26 10:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 15:27 [PATCH 0/3] kselftest/arm64: Update sve-ptrace for ABI changes Mark Brown
2025-05-23 15:27 ` [PATCH 1/3] kselftest/arm64: Fix check for setting new VLs in sve-ptrace Mark Brown
2025-05-26 10:30 ` Mark Rutland
2025-05-26 10:53 ` Dev Jain
2025-05-23 15:27 ` [PATCH 2/3] kselftest/arm64: Fix test for streaming FPSIMD write " Mark Brown
2025-05-26 10:44 ` Mark Rutland [this message]
2025-05-23 15:27 ` [PATCH 3/3] kselftest/arm64: Specify SVE data when testing VL set " Mark Brown
2025-05-26 10:57 ` Mark Rutland
2025-05-26 10:23 ` [PATCH 0/3] kselftest/arm64: Update sve-ptrace for ABI changes Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDRGGDgQtlh8sew6@J2N7QTR9R3 \
--to=mark.rutland@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox