Re: [PATCH v2 3/4] dt-bindings: crypto: fsl,sec-v4.0: Add power domains for iMX8QM and iMX8QXP

[John Ernberg <john.ernberg@actia.se>]

Hi Krzysztof,

On Tue, May 27, 2025 at 09:19:22AM +0200, Krzysztof Kozlowski wrote:
> On 27/05/2025 09:16, John Ernberg wrote:
> > 
> > diff --git a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml
> > index 75afa441e019..a3c938eb553e 100644
> > --- a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml
> > +++ b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml
> > @@ -48,6 +48,9 @@ properties:
> >                - fsl,imx6ul-caam
> >                - fsl,sec-v5.0
> >            - const: fsl,sec-v4.0
> > +      - items:
> > +          - const: fsl,imx8qm-caam
> 
> That's part of previous enum, no?
> 
> > +          - const: fsl,sec-v4.0
> >        - const: fsl,sec-v4.0
> >  
> >    reg:
> > @@ -77,6 +80,9 @@ properties:
> >    interrupts:
> >      maxItems: 1
> >  
> > +  power-domains:
> > +    maxItems: 1
> > +
> >    fsl,sec-era:
> >      description: Defines the 'ERA' of the SEC device.
> >      $ref: /schemas/types.yaml#/definitions/uint32
> > @@ -108,6 +114,9 @@ patternProperties:
> >            - items:
> >                - const: fsl,sec-v5.0-job-ring
> >                - const: fsl,sec-v4.0-job-ring
> > +          - items:
> > +              - const: fsl,imx8qm-job-ring
> 
> Combine with previous entry into enum.
> 

I think I managed to confuse myself around how compatible enums work first time around, thanks for prompting me to look again, I hopefully understand better now.

Will take care of this for V3.

Thanks! // John Ernberg