Re: [PATCH 1/1] dt-bindings: soc: add vf610 reset controller

[Frank Li <Frank.li@nxp.com>]

On Mon, May 26, 2025 at 04:54:30PM +0100, Conor Dooley wrote:
> On Thu, May 22, 2025 at 05:39:50PM -0400, Frank Li wrote:
> > Add vf610 reset controller, which used to reboot system to fix below
> > CHECK_DTB warnings:
> >
> > arch/arm/boot/dts/nxp/vf/vf610-bk4.dtb: /soc/bus@40000000/src@4006e000:
> >     failed to match any schema with compatible: ['fsl,vf610-src', 'syscon']
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  .../bindings/soc/fsl/fsl,vf610-src.yaml       | 46 +++++++++++++++++++
> >  1 file changed, 46 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/soc/fsl/fsl,vf610-src.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/soc/fsl/fsl,vf610-src.yaml b/Documentation/devicetree/bindings/soc/fsl/fsl,vf610-src.yaml
> > new file mode 100644
> > index 0000000000000..4c92a5e4892bf
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/fsl/fsl,vf610-src.yaml
> > @@ -0,0 +1,46 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas//soc/fsl/fsl,vf610-src.yaml#
>
> It's a reset controller then, shouldn't it be in /reset, not //soc?

It is not reset controller since there are not #reset-cells property to
reset other models. It just provides syscon to reboot the whole system.

Frank

>
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Freescale vf610 System Reset Controller
> > +
> > +maintainers:
> > +  - Frank Li <Frank.Li@nxp.com>
> > +
> > +description:
> > +  The System Reset Controller (SRC) generates the resets for the device. The
> > +  functional reset sources are programmable as either reset or interrupt. The
> > +  block also generates interrupts for various device events.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - fsl,vf610-src
> > +      - const: syscon
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    reset@4006e000 {
>
> The generic node name here is reset-controller
>
> > +        compatible = "fsl,vf610-src", "syscon";
> > +        reg = <0x4006e000 0x1000>;
> > +        interrupts = <96 IRQ_TYPE_LEVEL_HIGH>;
> > +    };
> > +
> > --
> > 2.34.1
> >