Re: [PATCH v5 03/29] iommu: Apply the new iommufd_object_alloc_ucmd helper

Jason Gunthorpe
2025-05-28T17:07:18Z

On Sat, May 17, 2025 at 08:21:20PM -0700, Nicolin Chen wrote:
> Now the new ucmd-based object allocator eases the finalize/abort routine,
> apply this to all existing allocators that aren't protected by any lock.
>
> Upgrade the for-driver vIOMMU alloctor too, and pass down to all existing
> viommu_alloc op accordingly.
>
> Note that __iommufd_object_alloc_ucmd() builds in some static tests that
> cover both static_asserts in the iommufd_viommu_alloc(). Thus drop them.
>
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 2 +-
> include/linux/iommu.h | 6 +++---
> include/linux/iommufd.h | 9 +++------
> .../arm/arm-smmu-v3/arm-smmu-v3-iommufd.c | 4 ++--
> drivers/iommu/iommufd/eventq.c | 14 ++++---------
> drivers/iommu/iommufd/selftest.c | 4 ++--
> drivers/iommu/iommufd/viommu.c | 20 ++++---------------
> 7 files changed, 19 insertions(+), 40 deletions(-)

Good diffstat..

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason