Re: [PATCH v5 10/29] iommufd: Abstract iopt_pin_pages and iopt_unpin_pages helpers

Jason Gunthorpe
2025-06-05T15:21:21Z

On Wed, Jun 04, 2025 at 09:11:07PM -0700, Nicolin Chen wrote:

> I found the entire ictx would be locked by iommufd_access_create(),
> then the release fop couldn't even get invoked to destroy objects.

Yes, that makes sense..

It looks to me like you can safely leave ictx as NULL instead of
adding a flag? That would be nicer than leaving a unrefcounted
pointer floating around..

Jason