Re: [PATCH v5 09/29] iommufd: Do not unmap an owned iopt_area

Nicolin Chen
2025-05-28T18:10:32Z

On Wed, May 28, 2025 at 02:08:45PM -0300, Jason Gunthorpe wrote:
> Fundamentally this is supporting accesses that don't have an unmap op
> callback.

Ah, I see.

> It could be done differently, with the below just create your access
> with a null ops. Prevent mdev drivers from doing this when they create
> their accesses. We don't need to optimize this failure case so it is
> fine to scan the xarray. All we really need to do here is eliminate
> the WARN_ON.

Yes. That approach looks much cleaner.

Will replace the iopt_pin_pages patch.

Thanks
Nicolin