Re: [PATCH v5 01/29] iommufd: Apply obvious cosmetic fixes

Jason Gunthorpe
2025-05-28T17:07:26Z

On Sat, May 17, 2025 at 08:21:18PM -0700, Nicolin Chen wrote:
> Run clang-format but exclude those not so obvious ones, which leaves us:
> - Align indentations
> - Add missing spaces
> - Remove unnecessary spaces
> - Remove unnecessary line wrappings
>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
> drivers/iommu/iommufd/io_pagetable.h | 2 +-
> drivers/iommu/iommufd/iommufd_private.h | 6 ++----
> include/linux/iommufd.h | 5 +++--
> drivers/iommu/iommufd/device.c | 3 +--
> drivers/iommu/iommufd/hw_pagetable.c | 6 ++----
> drivers/iommu/iommufd/io_pagetable.c | 3 +--
> drivers/iommu/iommufd/iova_bitmap.c | 1 -
> drivers/iommu/iommufd/main.c | 6 ++----
> drivers/iommu/iommufd/pages.c | 9 ++++-----
> drivers/iommu/iommufd/selftest.c | 24 +++++++++++-------------
> 10 files changed, 27 insertions(+), 38 deletions(-)

I have mixed feelings, I know people don't like churn, but it doesn't
seem so bad..

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason