Re: [PATCH v5 21/29] iommufd: Allow an input data_type via iommu_hw_info

Nicolin Chen
2025-05-30T17:24:36Z

On Fri, May 30, 2025 at 01:52:18PM -0300, Jason Gunthorpe wrote:
> On Sat, May 17, 2025 at 08:21:38PM -0700, Nicolin Chen wrote:
> > @@ -666,7 +678,7 @@ struct iommu_hw_info {
> > __u32 dev_id;
> > __u32 data_len;
> > __aligned_u64 data_uptr;
> > - __u32 out_data_type;
> > + __u32 data_type;
>
> It would be better to avoid changing this name, maybe stick a union
> around it?

Yes. I think a union is nicer.

Thanks!
Nicolin