From: Yeoreum Yun <yeoreum.yun@arm.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: sudeep.holla@arm.com, peterhuewe@gmx.de, jgg@ziepe.ca,
stuart.yoder@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org
Subject: Re: [PATCH 2/2] tpm: tpm_crb_ffa: maunally register tpm_crb_ffa driver when it's built-in
Date: Fri, 6 Jun 2025 19:12:43 +0100 [thread overview]
Message-ID: <aEMvm2MW9bBXf2gM@e129823.arm.com> (raw)
In-Reply-To: <aEMdGXXBSym7cXmK@kernel.org>
Hi Jarkko,
> > To integrate tpm_event_log with IMA subsystem,
> > tpm_crb and tpm_crb_ffa driver should be built as built-in
> > (CONFIG_TCG_CRB=y && CONFIG_TCG_CRB_FFA=y).
> >
> > However, this could make failure for ima_init() gets tpm chip when
> > each initcall function deployed like:
> >
> > 0000000000000888 l .initcall6.init 0000000000000000 crb_acpi_driver_init
> > 000000000000088c l .initcall6.init 0000000000000000 tpm_crb_ffa_driver_init
>
> The only failure I see is the patch 1/2 which changes init call level,
> and leaves kernel Git to a broken state.
>
> It breaks the famous "zero regressions policy".
>
> BR, Jarkko
Sorry, would you let me know what is broken more detail?
IMHO, by changing the init call level for ffa_init()
it's called early than before device_initcall() and it seems not to
break anything.
What breaks do you mean?
Thanks.
--
Sincerely,
Yeoreum Yun
next prev parent reply other threads:[~2025-06-06 18:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 10:57 [PATCH 0/2] fix failure of integration between tpm_crb_ffa with ima Yeoreum Yun
2025-06-06 10:57 ` [PATCH 1/2] firmware: arm_ffa: Change initcall level of ffa_init() to rootfs_initcall Yeoreum Yun
2025-06-06 10:57 ` [PATCH 2/2] tpm: tpm_crb_ffa: maunally register tpm_crb_ffa driver when it's built-in Yeoreum Yun
2025-06-06 16:53 ` Jarkko Sakkinen
2025-06-06 18:12 ` Yeoreum Yun [this message]
2025-06-09 20:59 ` Jarkko Sakkinen
2025-06-10 5:56 ` Yeoreum Yun
2025-06-10 12:17 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEMvm2MW9bBXf2gM@e129823.arm.com \
--to=yeoreum.yun@arm.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stuart.yoder@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).