From: Shawn Guo <shawnguo2@yeah.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Xu Yang <xu.yang_2@nxp.com>, Peter Chen <peter.chen@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
imx@lists.linux.dev, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: i.MX kernel hangup caused by chipidea USB gadget driver
Date: Tue, 10 Jun 2025 18:08:23 +0800 [thread overview]
Message-ID: <aEgEF6YKYccequVw@dragon> (raw)
In-Reply-To: <c7bfdfec-bc49-4ce5-8dd9-7a69d8e24ceb@rowland.harvard.edu>
Hi Alan,
On Mon, Jun 09, 2025 at 09:54:45AM -0400, Alan Stern wrote:
> On Mon, Jun 09, 2025 at 07:53:22PM +0800, Xu Yang wrote:
> > Hi Shawn,
> >
> > Thanks for your reports!
> >
> > On Mon, Jun 09, 2025 at 01:31:06PM +0800, Shawn Guo wrote:
> > > Hi Xu, Peter,
> > >
> > > I'm seeing a kernel hangup on imx8mm-evk board. It happens when:
> > >
> > > - USB gadget is enabled as Ethernet
> > > - There is data transfer over USB Ethernet
> > > - Device is going in/out suspend
>
> > During the scp process, the usb host won't put usb device to suspend state.
> > In current design, then the ether driver doesn't know the system has
> > suspended after echo mem. The root cause is that ether driver is still tring
> > to queue usb request after usb controller has suspended where usb clock is off,
> > then the system hang.
> >
> > With the above changes, I think the ether driver will fail to eth_start_xmit()
> > at an ealier stage, so the issue can't be triggered.
> >
> > I think the ether driver needs call gether_suspend() accordingly, to do this,
> > the controller driver need explicitly call suspend() function when it's going
> > to be suspended. Could you check whether below patch fix the issue?
>
> The situation is more complicated than this.
>
> In general, a USB gadget cannot allow itself to be suspended while the
> USB bus it is connected to remains active. Not unless it can be set to
> wake up when a USB packet arrives, and even that probably won't work
> because the wakeup sequence would take too long and the USB transfer
> would time out on the host.
>
> The best way to fix this problem is for the gadget to disconnect itself
> from the USB bus whenever it goes into suspend, and to reconnect when it
> resumes.
Thank you so much for the insight! It matches my testing pretty well.
The disconnect/reconnect gadget in udc suspend/resume is more reliable
than suspend/resume gadget.
Shawn
next prev parent reply other threads:[~2025-06-10 10:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 5:31 i.MX kernel hangup caused by chipidea USB gadget driver Shawn Guo
2025-06-09 11:53 ` Xu Yang
2025-06-09 13:54 ` Alan Stern
2025-06-10 10:08 ` Shawn Guo [this message]
2025-06-10 11:27 ` Xu Yang
2025-06-09 14:17 ` John Ernberg
2025-06-10 2:12 ` Peter Chen (CIX)
2025-06-10 10:17 ` Shawn Guo
2025-06-10 11:33 ` Xu Yang
2025-06-10 3:04 ` Shawn Guo
2025-06-10 15:03 ` John Ernberg
2025-06-10 11:30 ` Xu Yang
2025-06-10 15:05 ` John Ernberg
2025-06-12 13:23 ` John Ernberg
2025-06-13 3:13 ` Xu Yang
2025-06-10 9:50 ` Shawn Guo
2025-06-10 11:54 ` Xu Yang
2025-06-11 2:59 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEgEF6YKYccequVw@dragon \
--to=shawnguo2@yeah.net \
--cc=imx@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).