From: Geraldo Nascimento <geraldogabriel@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-rockchip@lists.infradead.org,
"Hugh Cole-Baker" <sigmaris@gmail.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/2] PCI: rockchip-host: Retry link training on failure without PERST#
Date: Tue, 10 Jun 2025 15:48:03 -0300 [thread overview]
Message-ID: <aEh949r9mwY-R0XD@geday> (raw)
In-Reply-To: <20250610184449.GA819185@bhelgaas>
On Tue, Jun 10, 2025 at 01:44:49PM -0500, Bjorn Helgaas wrote:
> This *looks* like it could be strictly a move of
> rockchip_pcie_set_vpcie(), without changing it at all.
Hi Bjorn,
yes, a move of rockchip_pcie_set_vpcie() is needed for re-enabling
power rails, considering patch 2/2 was also applied and the regulator
is not always-on anymore.
> If that's the case, please make the move a separate patch so it's more
> obvious what the interesting changes that actually make a difference
> are.
Good idea, I'll send v3.
Thank you!
Geraldo Nascimento
next prev parent reply other threads:[~2025-06-10 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 16:36 [RFC PATCH v2 0/2] PCI: rockchip-host: Support quirky devices Geraldo Nascimento
2025-06-10 16:37 ` [RFC PATCH v2 1/2] PCI: rockchip-host: Retry link training on failure without PERST# Geraldo Nascimento
2025-06-10 18:44 ` Bjorn Helgaas
2025-06-10 18:48 ` Geraldo Nascimento [this message]
2025-06-10 16:37 ` [RFC PATCH v2 2/2] arm64: dts: rockchip: drop PCIe 3v3 always-on and boot-on Geraldo Nascimento
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEh949r9mwY-R0XD@geday \
--to=geraldogabriel@gmail.com \
--cc=bhelgaas@google.com \
--cc=heiko@sntech.de \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=sigmaris@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).