From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BAA8C71136 for ; Mon, 16 Jun 2025 12:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/ZGzKTQYmPLXDmQRK/xhv75pjEAcmTJ3e/dH6xJaWm4=; b=W6Xe4M49jSfE8UpHo5maEMqlCu tjC30S4fg+saoqx01a4rAu4B+XI5lK7aGXs8pjKlgOosSmuF3iboaeM7hFPVS45YfejXteTrt4XUC c9gVdPszZI+JmezpG/W3VtpTbq+kKNNEsxZm2qmiJkMzs/PEvDHZI1FCgp7s/wlz81w6VsmCP0QjE D5gly+tzdChkqfUdpvnKokV2XyIL0GpX2YPfzo5I4wXRQ4+EG7XuUia5maAOUJQMc2CFm3gnCf6jY 8i+u3zL5k5fJC2bQZuB3dkuMAZFHtX9ZRkY0ogm4jfr3PsA/6cqf0/WWx5Z94OzVJafgKR1O+05/A FAp2MFQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uR8yb-00000004NFx-3iMA; Mon, 16 Jun 2025 12:30:13 +0000 Received: from mgamail.intel.com ([198.175.65.10]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uR84v-00000004D5Y-16hS for linux-arm-kernel@lists.infradead.org; Mon, 16 Jun 2025 11:32:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750073561; x=1781609561; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=K9KWXjUK6ETi9gIw9hOQRn1dglxLURauDPg1WLVBpa8=; b=CyKhp/D3/JJMMAs8GW+FjEZduDgoRgUsLkvSbp2N8HlvTfnjC5s1am0v AOLkhHBUABr/QEFqWFwYc8G0/6r6sIkZJJXhgJekeDuZcwYdjmLhWq2bg WtcxOpl8gFSssQR5ZIPkKTfHEKzJtpg5xaDQwRtnMmMPitYxBSbmlxo9b g2vRnlBmrlMe4qNSciagGlWnRVdPl3NDW8KGjlouR5Q/Nrlyk7nxs6WMj 7qTugu4VWkzEFGCkrgAbFk4TVaHEFb7g2ava+VWJDMBjGYPjyS9GxJaGC UNKdiDyryp9CE6GNI1PIa6fr6twMFArg9WhwU87EHDHn9bF58+RhH3trD A==; X-CSE-ConnectionGUID: u9C/ZRniTzq3KA6n248dRg== X-CSE-MsgGUID: WBKucV+DRDiLXBj0xuAPYw== X-IronPort-AV: E=McAfee;i="6800,10657,11465"; a="69657582" X-IronPort-AV: E=Sophos;i="6.16,241,1744095600"; d="scan'208";a="69657582" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2025 04:32:36 -0700 X-CSE-ConnectionGUID: QDgnZjIbTNK2iCkDaWZJzA== X-CSE-MsgGUID: eGPeF19JQ0WYvqZkT3eomA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,241,1744095600"; d="scan'208";a="152281049" Received: from smile.fi.intel.com ([10.237.72.52]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2025 04:32:25 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uR84a-000000073ib-42pq; Mon, 16 Jun 2025 14:32:20 +0300 Date: Mon, 16 Jun 2025 14:32:20 +0300 From: Andy Shevchenko To: Saravana Kannan Cc: Herve Codina , Andrew Lunn , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Rob Herring , Bjorn Helgaas , Mark Brown , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Wolfram Sang , Geert Uytterhoeven , Davidlohr Bueso , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v3 06/28] driver core: fw_devlink: Introduce fw_devlink_set_device() Message-ID: References: <20250613134817.681832-1-herve.codina@bootlin.com> <20250613134817.681832-7-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250616_043241_349015_D81A34F9 X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 13, 2025 at 02:13:49PM -0700, Saravana Kannan wrote: > On Fri, Jun 13, 2025 at 6:49 AM Herve Codina wrote: > > Setting fwnode->dev is specific to fw_devlink. > > > > In order to avoid having a direct 'fwnode->dev = dev;' in several > > place in the kernel, introduce fw_devlink_set_device() helper to perform > > this operation. > > This should not be set anywhere outside the driver core files. I'll > get to reviewing the series Strictly speaking I agree with you, but this is not a some driver case, it's very special and also we have some (ab)users of it. I can relax the requirement to not set outside of a core functionality, (like driver core, PCI core) which are tightly related to driver core one. Just my 2c. -- With Best Regards, Andy Shevchenko