From: Frank Li <Frank.li@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Adam Ford <aford173@gmail.com>,
linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: imx8mm: Configure DMA on UART2
Date: Mon, 23 Jun 2025 11:29:02 -0400 [thread overview]
Message-ID: <aFlyvv8GcbQiUvtO@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <CAOMZO5DUVVBmxfrJPjcZPCQGFg-rVNTUch6APWfSKF6LY1DWHQ@mail.gmail.com>
On Sat, Jun 21, 2025 at 02:07:56PM -0300, Fabio Estevam wrote:
> On Sat, Jun 21, 2025 at 8:23 AM Adam Ford <aford173@gmail.com> wrote:
> >
> > UART2 is often used as the console, so the DMA was likely left
> > off on purpose, since it's recomended to not use the DMA on the
>
> Typo: recommended
>
>
> > console. Beacause, the driver checks to see if the UART is used for
>
> Typo: Because
>
> > the console when determining if it should initialize DMA, it
> > should be safe to enable DMA on UART2 for all users.
>
> The same comment applies to the other patch.
Please run below command to check spell error before post patches.
./scripts/checkpatch.pl --codespell --strict
Frank
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
prev parent reply other threads:[~2025-06-23 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-21 11:23 [PATCH 1/2] arm64: dts: imx8mm: Configure DMA on UART2 Adam Ford
2025-06-21 11:23 ` [PATCH 2/2] arm64: dts: imx8mn: " Adam Ford
2025-06-21 17:07 ` [PATCH 1/2] arm64: dts: imx8mm: " Fabio Estevam
2025-06-23 15:29 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFlyvv8GcbQiUvtO@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox