linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: iproc: Remove description of 'msi_domain' in struct iproc_msi
@ 2025-07-08  5:38 Nam Cao
  2025-07-08 16:06 ` Bjorn Helgaas
  2025-07-09  1:17 ` kernel test robot
  0 siblings, 2 replies; 3+ messages in thread
From: Nam Cao @ 2025-07-08  5:38 UTC (permalink / raw)
  To: Thomas Gleixner, Lorenzo Pieralisi, Krzysztof Wilczyński,
	Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas, Ray Jui,
	Scott Branden, Broadcom internal kernel review list, linux-pci,
	linux-arm-kernel, linux-kernel
  Cc: Nam Cao, kernel test robot

The member msi_domain of struct iproc_msi has been removed, but its
description was left behind. Remove the description.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507080437.HQuYK7x8-lkp@intel.com/
Signed-off-by: Nam Cao <namcao@linutronix.de>
---
 drivers/pci/controller/pcie-iproc-msi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c
index d0c7f004217f..9ba242ab9596 100644
--- a/drivers/pci/controller/pcie-iproc-msi.c
+++ b/drivers/pci/controller/pcie-iproc-msi.c
@@ -82,7 +82,6 @@ struct iproc_msi_grp {
  * @bitmap_lock: lock to protect access to the MSI bitmap
  * @nr_msi_vecs: total number of MSI vectors
  * @inner_domain: inner IRQ domain
- * @msi_domain: MSI IRQ domain
  * @nr_eq_region: required number of 4K aligned memory region for MSI event
  * queues
  * @nr_msi_region: required number of 4K aligned address region for MSI posted
-- 
2.39.5



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: iproc: Remove description of 'msi_domain' in struct iproc_msi
  2025-07-08  5:38 [PATCH] PCI: iproc: Remove description of 'msi_domain' in struct iproc_msi Nam Cao
@ 2025-07-08 16:06 ` Bjorn Helgaas
  2025-07-09  1:17 ` kernel test robot
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2025-07-08 16:06 UTC (permalink / raw)
  To: Nam Cao
  Cc: Thomas Gleixner, Lorenzo Pieralisi, Krzysztof Wilczyński,
	Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas, Ray Jui,
	Scott Branden, Broadcom internal kernel review list, linux-pci,
	linux-arm-kernel, linux-kernel, kernel test robot

On Tue, Jul 08, 2025 at 07:38:25AM +0200, Nam Cao wrote:
> The member msi_domain of struct iproc_msi has been removed, but its
> description was left behind. Remove the description.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507080437.HQuYK7x8-lkp@intel.com/
> Signed-off-by: Nam Cao <namcao@linutronix.de>

Thanks for squashing this into the ("PCI: iproc: Switch to
msi_create_parent_irq_domain()") patch that removed the msi_domain
member, Mani.  No point in cluttering the history with extra commits
that clean up things we haven't merged upstream yet.

> ---
>  drivers/pci/controller/pcie-iproc-msi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-iproc-msi.c b/drivers/pci/controller/pcie-iproc-msi.c
> index d0c7f004217f..9ba242ab9596 100644
> --- a/drivers/pci/controller/pcie-iproc-msi.c
> +++ b/drivers/pci/controller/pcie-iproc-msi.c
> @@ -82,7 +82,6 @@ struct iproc_msi_grp {
>   * @bitmap_lock: lock to protect access to the MSI bitmap
>   * @nr_msi_vecs: total number of MSI vectors
>   * @inner_domain: inner IRQ domain
> - * @msi_domain: MSI IRQ domain
>   * @nr_eq_region: required number of 4K aligned memory region for MSI event
>   * queues
>   * @nr_msi_region: required number of 4K aligned address region for MSI posted
> -- 
> 2.39.5
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: iproc: Remove description of 'msi_domain' in struct iproc_msi
  2025-07-08  5:38 [PATCH] PCI: iproc: Remove description of 'msi_domain' in struct iproc_msi Nam Cao
  2025-07-08 16:06 ` Bjorn Helgaas
@ 2025-07-09  1:17 ` kernel test robot
  1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2025-07-09  1:17 UTC (permalink / raw)
  To: Nam Cao, Thomas Gleixner, Lorenzo Pieralisi,
	Krzysztof Wilczyński, Manivannan Sadhasivam, Rob Herring,
	Bjorn Helgaas, Ray Jui, Scott Branden,
	Broadcom internal kernel review list, linux-pci, linux-arm-kernel,
	linux-kernel
  Cc: llvm, oe-kbuild-all, Nam Cao, kernel test robot

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

Hi Nam,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.16-rc5 next-20250708]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nam-Cao/PCI-iproc-Remove-description-of-msi_domain-in-struct-iproc_msi/20250708-133907
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20250708053825.1803409-1-namcao%40linutronix.de
patch subject: [PATCH] PCI: iproc: Remove description of 'msi_domain' in struct iproc_msi
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
config: arm-randconfig-001-20250708 (attached as .config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 01c97b4953e87ae455bd4c41e3de3f0f0f29c61c)
reproduce (this is a W=1 build): (attached as reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507090000.aEkXHYpK-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> Warning: drivers/pci/controller/pcie-iproc-msi.c:108 struct member 'msi_domain' not described in 'iproc_msi'

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38104 bytes --]

[-- Attachment #3: reproduce --]
[-- Type: text/plain, Size: 911 bytes --]

reproduce (this is a W=1 build):
        git clone https://github.com/intel/lkp-tests.git ~/lkp-tests
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # clang-21 might not be officially released. Try a lower version if installation fails.
        git remote add pci https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git
        git fetch pci next
        git checkout pci/next
        b4 shazam https://lore.kernel.org/r/20250708053825.1803409-1-namcao@linutronix.de
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang-21 ~/lkp-tests/kbuild/make.cross W=1 O=build_dir ARCH=arm olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang-21 ~/lkp-tests/kbuild/make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/pci/controller/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-07-09  1:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-08  5:38 [PATCH] PCI: iproc: Remove description of 'msi_domain' in struct iproc_msi Nam Cao
2025-07-08 16:06 ` Bjorn Helgaas
2025-07-09  1:17 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).