From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94A1CC83030 for ; Mon, 30 Jun 2025 21:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/n8VfpILnh3xTd/ry0xCdOmAPegbbmqua23xjp6yCbU=; b=xff8FTSjCsWjvW+9gzsiBCsPd+ lltS5ci3G+UvUxDQQStw20Gnqpg6f068oGBE2kaC4b+MBLIvVzxi/FSGs7HFByDQCeYGurMTtEUDM NfpSalosK+zbZCMPrMNhsaEmwzhy/v8Ce7De5cSYeOnd8NSoa69uZ6b6x2FwUJUAYJ0YgKv8OLq5h Grv8yi8sYkNrEO+yeuDEPA2WUBVVwBKs7k/0xN4BZI717vMVXiScSPtGiWi5NsJspz9jlvbNkLcqz qmL6hWdxqoKKpH63Un9JS5d9S1MFNCkCgy4Rvn6B51jgc1VzI92PUOcCd2HMkGes8z4FZRKXfuj5B TC7OHmCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWMJi-00000003Vts-2zSk; Mon, 30 Jun 2025 21:45:34 +0000 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWMHO-00000003VXR-3Vj1; Mon, 30 Jun 2025 21:43:11 +0000 Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-4a5903bceffso67883141cf.3; Mon, 30 Jun 2025 14:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751319790; x=1751924590; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=/n8VfpILnh3xTd/ry0xCdOmAPegbbmqua23xjp6yCbU=; b=BkSeG8Ga/k9h+doH+0tgUgpkRnsYExwk+9L6wzrFuWHTq4ocqDsHOrtb97HY3KX7OQ I3Syp1Ff/aIvM8ijwHMZKsYZEN7MZOcMqLJxdbDLhZZK6x0amLKRK44RwnC0rtQOM82y r76sqghHiM7TqkjUGuf1y9BJX+z20Su0JVJ+2lPPhgVfe4JmPsVeY/G/6RufUxvGpG+6 bM3nxBFsKG5KSPQeagTq1SldHcsLDDvUovMoabeEoyzs9VHPGVwL3Eqa7QbwFXBTkvpm PMdcq16gjDR3ioeCcutHZNQYMS1DfM7Zczo3PIrBbTD5RK5jt1PjPiQMkUEWVI1z6ykK 55QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751319790; x=1751924590; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/n8VfpILnh3xTd/ry0xCdOmAPegbbmqua23xjp6yCbU=; b=IJnz4L+A2mSKVe28G8muvkpVjUh09dXcotp73bhff+LH1e5lHRgwKQBF/H5N1HMLXH hEez6n3F5BuoMfGm/U2hZRW4v9oyY8RdPTXoqc6RPwRMjsvSx2N2RzKglMOeyuEaupMl a5HojpWG9zcG2kfCMaq7HiukcxdQJbzTXPh/0yuvdRTRG5uMp21wlcG40bn2AKpM1vGd Lzp2lW/EryEdBRUu0YawFs2JjW+CGWt/pvrWsPPVaJa3ZPxazdPVTaO2YT4GtAMdcdjJ v2tcMOrwKdm0xY4YRApCrnDWBDFHXJAmQSTPHvmSuerq7cwf3lo9QyczR7AqHvEET7zi OMXA== X-Forwarded-Encrypted: i=1; AJvYcCUA5aF9o7qoU5QQTTxwYXsI24NC0Fpzag+sBWYopFivsgvCavzBjzoE2OSO6tHe+hnEdJ0/NvdKu2Bw@lists.infradead.org, AJvYcCWvkyzXkl+0ktNMchycHSexX9K3pfYD8sFoGRnUuX1iQjqS8T0fnqHhRKGWBR4wLxh1mtBNS9vbwcSgHaHG/EH6@lists.infradead.org X-Gm-Message-State: AOJu0YxPA0K4RchpXBeP1KKknQYtQqv+URDeAuiV3W3bskOwEHRLTErE ia6Lpd1j0DaZMMEYNNxBdEKSieTxCnxGQNfet5HkQ2Ckwb8gbYeH1PGP X-Gm-Gg: ASbGnct1+ePlq4W9ZD3Ncy622aaJKl0m10pDlTyYN0fMmKxm9ea2/Ot3dDadId67dWV o2r4hGHBq22qjySx7aiQOGBEqZAmJr2Z3BQGPsIG/XlIiTtg7a3jPcdLGlv//ZkSiNLOgHGr00q L96rKS3Hifb1WyuLorj8D14MmOeD6j3Zt7ajoi6uzoT/I8gtfulFv2hFFIDw0vLHgODtnea0VI7 UYWaGcoofuL9buZmCI8toqArvWerWfC+fQxLSQYnmg978LtfpPkCq1Fg3yEV2R35wJWF8HEK3dx OHbKXdnIA4B4aK/PmwkCtCOKPDzU8n2o1V2pT5IOEUNDG74TSQ== X-Google-Smtp-Source: AGHT+IGgiesFUWV/yzbfRLw9KUgtdZVfuq32iKhJIw8iUWSflMfyK58IUhuPCz10MrQuAnv+l4ThFw== X-Received: by 2002:a05:622a:578d:b0:4a4:40b7:9cc with SMTP id d75a77b69052e-4a7fc9f8ee0mr225437281cf.12.1751319789601; Mon, 30 Jun 2025 14:43:09 -0700 (PDT) Received: from geday ([2804:7f2:800b:4851::dead:c001]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a7fc138d7esm66590201cf.21.2025.06.30.14.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 14:43:08 -0700 (PDT) Date: Mon, 30 Jun 2025 18:43:02 -0300 From: Geraldo Nascimento To: Heiko =?utf-8?Q?St=C3=BCbner?= Cc: linux-rockchip@lists.infradead.org, Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Vinod Koul , Kishon Vijay Abraham I , Rick wertenbroek , Neil Armstrong , Valmantas Paliksa , linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 3/4] phy: rockchip-pcie: Enable all four lanes if required Message-ID: References: <4006908.X513TT2pbd@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4006908.X513TT2pbd@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250630_144310_875827_C3D9D751 X-CRM114-Status: GOOD ( 14.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 30, 2025 at 11:33:19PM +0200, Heiko Stübner wrote: > Am Montag, 30. Juni 2025, 20:22:01 Mitteleuropäische Sommerzeit schrieb Geraldo Nascimento: > > Current code enables only Lane 0 because pwr_cnt will be incremented on > > first call to the function. Let's reorder the enablement code to enable > > all 4 lanes through GRF. > > > > Reviewed-by: Neil Armstrong > > Reviewed-by: Robin Murphy > > > > Signed-off-by: Valmantas Paliksa > > Signed-off-by: Geraldo Nascimento > > hmm, if Valmantas is the original author you should probably keep that authorship > git commit --amend --author="Valmantas Paliksa " > should do the trick. > > The first signed-off should be from the patch author, then your signed-off > indicates you handling the patch later as part of this series. > > [or, if you modified the code of the patch heavily, Co-developed-by could > also be appropriate] > Hi Heiko, thanks for the pointer on doing things right. I'd hate to appropriate someone's else work. I already emailed Valmantas and he's fine with the inclusion of his signed-off, so let's give him due credit. Geraldo Nascimento > Heiko