From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69025C83F0C for ; Fri, 4 Jul 2025 11:22:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FQDUFQMpYBZyZW9ZhjtR2ZfDFJkoYa1flMXVmHEDmpE=; b=N8jmFKb0Yv54sRdkH8GmhlnI5r k1ngSGntomAGmqoFCoUunj7xOTGwAtOyh90CJXmooxKBQ28StklwyDJ5yZhd/8COJMutoYCKkK6sN auLKBRtkgYOTsaeR1xLqkqSuF6KgMEUZB6+UJQtEIQO6mAd3xRD2AmVsV0zOHhjGto3TZA01zKpOj dqml0pTAYJUwO6qbXgW+A99+TqJjlxwZ+pxAbtJYC0H8GQeH2SG4Gm2mcU+JuaoHVw2ZmD6NYUecA w9U1TDljlP4A+/vjo8r7bQoQpta+eZFyf31lpbSTJcM4g4SkZ9eYR4yfTDq3op4yZ3Hsz1n3KF2Wj yWH3TdDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uXeUY-0000000ECf2-06Ag; Fri, 04 Jul 2025 11:22:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uXcGT-0000000Dq4P-3uON for linux-arm-kernel@lists.infradead.org; Fri, 04 Jul 2025 08:59:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EAD5D152B; Fri, 4 Jul 2025 01:59:07 -0700 (PDT) Received: from bogus (e133711.arm.com [10.1.196.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A3D663F6A8; Fri, 4 Jul 2025 01:59:19 -0700 (PDT) Date: Fri, 4 Jul 2025 09:59:16 +0100 From: Sudeep Holla To: Peng Fan Cc: Chuck Cannon , Sudeep Holla , Souvik Chakravarty , Peng Fan , Cristian Marussi , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , , , , Subject: Re: [PATCH 2/7] firmware: arm_scmi: imx: Support discovering buildinfo of MISC protocol Message-ID: References: <20250627-sm-misc-api-v1-v1-0-2b99481fe825@nxp.com> <20250627-sm-misc-api-v1-v1-2-2b99481fe825@nxp.com> <20250704051204.GB4525@nxa18884-linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250704051204.GB4525@nxa18884-linux> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250704_015926_061133_A23BA866 X-CRM114-Status: GOOD ( 29.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 04, 2025 at 01:12:04PM +0800, Peng Fan wrote: > Hi Sudeep, > > On Wed, Jul 02, 2025 at 04:21:40PM +0100, Sudeep Holla wrote: > >On Fri, Jun 27, 2025 at 02:03:45PM +0800, Peng Fan wrote: > >> MISC protocol supports discovering the System Manager(SM) build > >> information including build commit, build time and etc. Add the API > >> for user to retrieve the information from SM. > >> > >> Signed-off-by: Peng Fan > >> --- > >> .../firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 35 ++++++++++++++++++++++ > >> include/linux/scmi_imx_protocol.h | 12 ++++++++ > >> 2 files changed, 47 insertions(+) > >> > >> diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c > >> index a8915d3b4df518719d56bfff38922625ad9b70f6..1b24d070c6f4856b92f515fcdba5836fd6498ce6 100644 > >> --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c > >> +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c > >> @@ -25,6 +25,7 @@ > >> enum scmi_imx_misc_protocol_cmd { > >> SCMI_IMX_MISC_CTRL_SET = 0x3, > >> SCMI_IMX_MISC_CTRL_GET = 0x4, > >> + SCMI_IMX_MISC_DISCOVER_BUILDINFO = 0x6, > > > >I clearly missed to raise this point when the documentation for this command > >was added. Anyways I assume, you had explored all the options before adding > >this as generic tools may not be able to pick this up. Instead, I would have > >just stuck with vendor version in the standard protocol with build number > >embedded into it. The date and other info must be implicit from the build. > > > >I try to be more cautious and ask questions in the future as I don't want > >vendor extensions to be dumping ground for really random things like this. > > +Souvik > > And Loop our firmware owner to help comment. I just add what the firmware > supports here and allow linux to see the information when the firmware > does not have uart output in some builds. > > From SCMI spec, it does not restrict what vendor extensions should be like > as I know. So I am not sure what we should do when we define vendor > extensions and what I should do next for this patch. > Just to be clear, I am not against vendor extensions. I am just saying this interface is not strictly needed. The vendor version could encode this nicely and you could have a map. The only and main concern is having such extensions will not help generic tools as these are very vendor specific. It is good to have firmware version and other related details in a standard format that anyone can understand without the need to dig deeper into vendor specific extensions. Again I am not saying to drop these interfaces, but you will get questioned for its use in the kernel if that doesn't seem like the right approach. -- Regards, Sudeep