Re: [PATCH net-next v2 1/7] dt-bindings: net: airoha: npu: Add memory regions used for wlan offload

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]

On Jul 07, Krzysztof Kozlowski wrote:
> On Sat, Jul 05, 2025 at 11:09:45PM +0200, Lorenzo Bianconi wrote:
> > Document memory regions used by Airoha EN7581 NPU for wlan traffic
> > offloading.
> > 
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  .../devicetree/bindings/net/airoha,en7581-npu.yaml   | 20 ++++++++++++++++----
> >  1 file changed, 16 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml b/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> > index 76dd97c3fb4004674dc30a54c039c1cc19afedb3..db9269d1801bafa9be3b6c199a9e30cd23f4aea9 100644
> > --- a/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> > +++ b/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> > @@ -41,15 +41,25 @@ properties:
> >        - description: wlan irq line5
> >  
> >    memory-region:
> > -    maxItems: 1
> > -    description:
> > -      Memory used to store NPU firmware binary.
> > +    items:
> > +      - description: NPU firmware binary region
> > +      - description: NPU wlan offload RX buffers region
> > +      - description: NPU wlan offload TX buffers region
> > +      - description: NPU wlan offload TX packet identifiers region
> > +
> > +  memory-region-names:
> > +    items:
> > +      - const: binary
> 
> Rather: firmware

ack, I will fix it.

> 
> > +      - const: pkt
> > +      - const: tx-pkt
> > +      - const: tx-bufid
> >  
> >  required:
> >    - compatible
> >    - reg
> >    - interrupts
> >    - memory-region
> > +  - memory-region-names
> 
> That's ABI break.
> 

ack, I will fix it.

Regards,
Lorenzo

> Best regards,
> Krzysztof
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]