From: Shawn Guo <shawnguo2@yeah.net>
To: Xu Yang <xu.yang_2@nxp.com>, Frank Li <Frank.Li@nxp.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, jun.li@nxp.com
Subject: Re: [PATCH] arm64: dts: imx95: add some USB3 PHY tuning properties
Date: Mon, 7 Jul 2025 16:21:00 +0800 [thread overview]
Message-ID: <aGuDbE1_9Sbug-NH@dragon> (raw)
In-Reply-To: <20250627031348.3455547-1-xu.yang_2@nxp.com>
On Fri, Jun 27, 2025 at 11:13:48AM +0800, Xu Yang wrote:
> Add some USB3 PHY tuning properties to imx95-15x15-evk and
> imx95-19x19-evk boards to improve USB signal quality.
>
> Reviewed-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts | 6 +++++-
> arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 4 ++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts b/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> index 6c47f4b47356..b26e9db7832a 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-15x15-evk.dts
> @@ -1069,8 +1069,12 @@ usb3_data_hs: endpoint {
> };
>
> &usb3_phy {
> - orientation-switch;
> + fsl,phy-pcs-tx-deemph-3p5db-attenuation-db = <17>;
> + fsl,phy-pcs-tx-swing-full-percent = <100>;
> fsl,phy-tx-preemp-amp-tune-microamp = <600>;
> + fsl,phy-tx-vboost-level-microvolt = <1156>;
> + fsl,phy-tx-vref-tune-percent = <100>;
> + orientation-switch;
> status = "okay";
It conflicts with what I applied from Frank [1].
Shawn
[1] https://lkml.org/lkml/2025/6/6/920
>
> port {
> diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> index 6886ea766655..e212f12f869a 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> @@ -514,7 +514,11 @@ usb3_data_hs: endpoint {
> };
>
> &usb3_phy {
> + fsl,phy-pcs-tx-deemph-3p5db-attenuation-db = <17>;
> + fsl,phy-pcs-tx-swing-full-percent = <100>;
> fsl,phy-tx-preemp-amp-tune-microamp = <600>;
> + fsl,phy-tx-vboost-level-microvolt = <1156>;
> + fsl,phy-tx-vref-tune-percent = <100>;
> orientation-switch;
> status = "okay";
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-07-07 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 3:13 [PATCH] arm64: dts: imx95: add some USB3 PHY tuning properties Xu Yang
2025-07-07 8:21 ` Shawn Guo [this message]
2025-07-07 9:00 ` Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGuDbE1_9Sbug-NH@dragon \
--to=shawnguo2@yeah.net \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox