Re: [PATCH v2 1/4] dt-bindings: media: add i.MX parallel csi support

[Frank Li <Frank.li@nxp.com>]

On Mon, Jul 07, 2025 at 09:01:48AM +0200, Krzysztof Kozlowski wrote:
> On Thu, Jul 03, 2025 at 02:33:06PM -0400, Frank Li wrote:
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - const: fsl,imx8qxp-pcif
> > +      - items:
> > +          - enum:
> > +              - fsl,imx91-pcif
> > +          - const: fsl,imx93-pcif
> > +      - const: fsl,imx93-pcif
>
> This one should be an enum with imx8qxp.
>
>
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 2
> > +
> > +  clock-names:
> > +    items:
> > +      - const: pixel
> > +      - const: ipg
> > +
> > +  power-domains:
> > +    maxItems: 1
> > +
> > +  ports:
> > +    $ref: /schemas/graph.yaml#/properties/ports
> > +
> > +    properties:
> > +      port@0:
> > +        $ref: /schemas/graph.yaml#/$defs/port-base
>
> Use the properties/port schema instead, you do not have any properties
> here (although then question - don't you need anything from video
> interfaces?)
>
> > +        unevaluatedProperties: false
> > +        description:
> > +          Input port node.
> > +
> > +      port@1:
> > +        $ref: /schemas/graph.yaml#/$defs/port-base
>
> Same here
>
> > +        unevaluatedProperties: false
> > +        description:
> > +          Output port node.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - clock-names
> > +  - power-domains
> > +  - ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/imx93-clock.h>
> > +    #include <dt-bindings/power/fsl,imx93-power.h>
> > +
> > +    pcif@4ac10070 {
>
> That's a CPI bus from MIPI so cpi@, no?

It is not MIPI.  It is old camera interface, which use D0..7 and VSYNC ...
signal.

So Laurent purpose 'pcif', is it okay?

Frank
>
> Best regards,
> Krzysztof
>