From: Vinod Koul <vkoul@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Rick Wertenbroek <rick.wertenbroek@gmail.com>,
rick.wertenbroek@heig-vd.ch, alberto.dassatti@heig-vd.ch,
Kishon Vijay Abraham I <kishon@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: rockchip-snps-pcie3: add support for rockchip,phy-ref-use-pad
Date: Tue, 22 Jul 2025 18:04:38 +0530 [thread overview]
Message-ID: <aH-FXrb-qvF3ffv1@vaman> (raw)
In-Reply-To: <5a7f47a7-c81e-4f70-9391-0dd1e3aa9f65@kernel.org>
On 16-07-25, 08:18, Damien Le Moal wrote:
> On 7/15/25 19:58, Rick Wertenbroek wrote:
> > &pcie30phy {
> > rockchip,rx-common-refclk-mode = <0 0 1 1>;
> > rockchip,phy-ref-use-pad = <0 1>;
> > clocks = <&cru PCLK_PCIE_COMBO_PIPE_PHY>, <&cru CLK_PHY0_REF_ALT_P>,
> > <&cru CLK_PHY0_REF_ALT_M>, <&cru CLK_PHY1_REF_ALT_P>,
> > <&cru CLK_PHY1_REF_ALT_M>;
> > clock-names = "pclk", "phy0_ref_alt_p",
> > "phy0_ref_alt_m", "phy1_ref_alt_p",
> > "phy1_ref_alt_m";
> > };
> > ---
> >
>
> This looks OK to me, but don't you need to also update the dt-bindings yaml to
> document this new "phy-ref-use-pad" property ?
Absolutely, without update to binding this is a no-go
--
~Vinod
prev parent reply other threads:[~2025-07-22 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 10:58 [PATCH] phy: rockchip-snps-pcie3: add support for rockchip,phy-ref-use-pad Rick Wertenbroek
2025-07-15 23:18 ` Damien Le Moal
2025-07-22 12:34 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aH-FXrb-qvF3ffv1@vaman \
--to=vkoul@kernel.org \
--cc=alberto.dassatti@heig-vd.ch \
--cc=dlemoal@kernel.org \
--cc=heiko@sntech.de \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rick.wertenbroek@gmail.com \
--cc=rick.wertenbroek@heig-vd.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox