Re: [PATCH net-next v3 1/7] dt-bindings: net: airoha: npu: Add memory regions used for wlan offload

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2151 bytes --]

On Jul 14, Rob Herring wrote:
> On Mon, Jul 14, 2025 at 05:25:14PM +0200, Lorenzo Bianconi wrote:
> > Document memory regions used by Airoha EN7581 NPU for wlan traffic
> > offloading.
> > 
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  .../devicetree/bindings/net/airoha,en7581-npu.yaml    | 19 +++++++++++++++----
> >  1 file changed, 15 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml b/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> > index 76dd97c3fb4004674dc30a54c039c1cc19afedb3..f99d60f75bb03931a1c4f35066c72c709e337fd2 100644
> > --- a/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> > +++ b/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> > @@ -41,9 +41,18 @@ properties:
> >        - description: wlan irq line5
> >  
> >    memory-region:
> > -    maxItems: 1
> > -    description:
> > -      Memory used to store NPU firmware binary.
> > +    items:
> > +      - description: NPU firmware binary region
> > +      - description: NPU wlan offload RX buffers region
> > +      - description: NPU wlan offload TX buffers region
> > +      - description: NPU wlan offload TX packet identifiers region
> 
> 1 entry was valid before, but not anymore? If so, justify it in the 
> commit message.

ack, I will do it in v4.

Regrads,
Lorenzo

> 
> > +
> > +  memory-region-names:
> > +    items:
> > +      - const: firmware
> > +      - const: pkt
> > +      - const: tx-pkt
> > +      - const: tx-bufid
> >  
> >  required:
> >    - compatible
> > @@ -79,6 +88,8 @@ examples:
> >                       <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
> >                       <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
> >                       <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>;
> > -        memory-region = <&npu_binary>;
> > +        memory-region = <&npu_firmware>, <&npu_pkt>, <&npu_txpkt>,
> > +                        <&npu_txbufid>;
> > +        memory-region-names = "firmware", "pkt", "tx-pkt", "tx-bufid";
> >        };
> >      };
> > 
> > -- 
> > 2.50.1
> > 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]