Re: [PATCH v3 00/10] perf: arm_spe: Armv8.8 SPE features

James Clark
2025-06-30T13:31:26Z

On 05/06/2025 11:48 am, James Clark wrote:
> Support 3 new SPE features: FEAT_SPEv1p4 filters, FEAT_SPE_EFT extended
> filtering, and SPE_FEAT_FDS data source filtering. The features are
> independent can be applied separately:
>
> * Prerequisite sysreg changes - patches 1 - 2
> * FEAT_SPEv1p4 - patch 3
> * FEAT_SPE_EFT - patch 4
> * FEAT_SPE_FDS - patches 5 - 8
> * FEAT_SPE_FDS Perf tool changes - patches 9 - 11
>
> The first two features will work with old Perfs but a Perf change to
> parse the new config4 is required for the last feature.
>
> To:
>
> ---
> Changes in v3:
> - Use PMSIDR_EL1_FDS instead of 1 << PMSIDR_EL1_FDS_SHIFT
> - Add VNCR offsets
> - Link to v2: https://lore.kernel.org/r/20250529-james-perf-feat_spe_eft-v2-0-a01a9baad06a@linaro.org
>
> Changes in v2:
> - Fix detection of FEAT_SPE_FDS in el2_setup.h
> - Pickup Marc Z's sysreg change instead which matches the json
> - Restructure and expand docs changes
> - Link to v1: https://lore.kernel.org/r/20250506-james-perf-feat_spe_eft-v1-0-dd480e8e4851@linaro.org
>
> ---
> James Clark (10):
> arm64: sysreg: Add new PMSFCR_EL1 fields and PMSDSFR_EL1 register
> perf: arm_spe: Support FEAT_SPEv1p4 filters
> perf: arm_spe: Add support for FEAT_SPE_EFT extended filtering
> arm64/boot: Enable EL2 requirements for SPE_FEAT_FDS
> KVM: arm64: Add trap configs for PMSDSFR_EL1
> perf: Add perf_event_attr::config4
> perf: arm_spe: Add support for filtering on data source
> tools headers UAPI: Sync linux/perf_event.h with the kernel sources
> perf tools: Add support for perf_event_attr::config4
> perf docs: arm-spe: Document new SPE filtering features
>
> Documentation/arch/arm64/booting.rst | 11 ++++
> arch/arm64/include/asm/el2_setup.h | 14 +++++
> arch/arm64/include/asm/sysreg.h | 7 +++
> arch/arm64/include/asm/vncr_mapping.h | 2 +
> arch/arm64/kvm/emulate-nested.c | 1 +
> arch/arm64/kvm/sys_regs.c | 1 +
> arch/arm64/tools/sysreg | 13 +++-
> drivers/perf/arm_spe_pmu.c | 100 +++++++++++++++++++++++++++++-
> include/uapi/linux/perf_event.h | 2 +
> tools/include/uapi/linux/perf_event.h | 2 +
> tools/perf/Documentation/perf-arm-spe.txt | 97 ++++++++++++++++++++++++++---
> tools/perf/tests/parse-events.c | 14 ++++-
> tools/perf/util/parse-events.c | 11 ++++
> tools/perf/util/parse-events.h | 1 +
> tools/perf/util/parse-events.l | 1 +
> tools/perf/util/pmu.c | 8 +++
> tools/perf/util/pmu.h | 1 +
> 17 files changed, 273 insertions(+), 13 deletions(-)
> ---
> base-commit: ec7714e4947909190ffb3041a03311a975350fe0
> change-id: 20250312-james-perf-feat_spe_eft-66cdf4d8fe99
>
> Best regards,

Gentle ping, thanks