From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Marc Zyngier <maz@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Sascha Bischoff <sascha.bischoff@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Timothy Hayes <timothy.hayes@arm.com>
Subject: Re: [PATCH v2 0/3] irqchip/gic-v5: Fix some static checker issues
Date: Fri, 18 Jul 2025 11:33:38 +0200 [thread overview]
Message-ID: <aHoU8sKPuyzEFRIn@lpieralisi> (raw)
In-Reply-To: <736d34e1-c72e-4176-becb-00f0b27be2bf@sabinyo.mountain>
On Thu, Jul 17, 2025 at 01:45:16PM -0500, Dan Carpenter wrote:
> These are few things that Smatch complained about.
>
> v2:
> I had a wrong goto in patch 3 so there was still a leak.
> Improve the naming.
>
> Dan Carpenter (3):
> irqchip/gic-v5: Delete a stray tab
> irqchip/gic-v5: Fix forever loop in gicv5_its_create_itt_two_level()
> error handling
> irqchip/gic-v5: Fix error handling in gicv5_its_irq_domain_alloc()
>
> drivers/irqchip/irq-gic-v5-irs.c | 2 +-
> drivers/irqchip/irq-gic-v5-its.c | 24 ++++++++++++++++--------
> 2 files changed, 17 insertions(+), 9 deletions(-)
I reviewed and tested these fixes by injecting an error in the ITS
IRQ domain allocation path for a multi-MSI device - code failed and
the retry (that is not there in the code for obvious reasons)
succeeded, so for the series:
Reviewed-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Tested-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
prev parent reply other threads:[~2025-07-18 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 18:45 [PATCH v2 0/3] irqchip/gic-v5: Fix some static checker issues Dan Carpenter
2025-07-18 9:33 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHoU8sKPuyzEFRIn@lpieralisi \
--to=lpieralisi@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=sascha.bischoff@arm.com \
--cc=tglx@linutronix.de \
--cc=timothy.hayes@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox