linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] irqchip/gic-v5: Fix some static checker issues
@ 2025-07-17 18:45 Dan Carpenter
  2025-07-18  9:33 ` Lorenzo Pieralisi
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-07-17 18:45 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: linux-arm-kernel, linux-kernel, Lorenzo Pieralisi,
	Sascha Bischoff, Thomas Gleixner, Timothy Hayes

These are few things that Smatch complained about.

v2:
I had a wrong goto in patch 3 so there was still a leak.
Improve the naming.

Dan Carpenter (3):
  irqchip/gic-v5: Delete a stray tab
  irqchip/gic-v5: Fix forever loop in gicv5_its_create_itt_two_level()
    error handling
  irqchip/gic-v5: Fix error handling in  gicv5_its_irq_domain_alloc()

 drivers/irqchip/irq-gic-v5-irs.c |  2 +-
 drivers/irqchip/irq-gic-v5-its.c | 24 ++++++++++++++++--------
 2 files changed, 17 insertions(+), 9 deletions(-)

-- 
2.47.2



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 0/3] irqchip/gic-v5: Fix some static checker issues
  2025-07-17 18:45 [PATCH v2 0/3] irqchip/gic-v5: Fix some static checker issues Dan Carpenter
@ 2025-07-18  9:33 ` Lorenzo Pieralisi
  0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2025-07-18  9:33 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Marc Zyngier, linux-arm-kernel, linux-kernel, Sascha Bischoff,
	Thomas Gleixner, Timothy Hayes

On Thu, Jul 17, 2025 at 01:45:16PM -0500, Dan Carpenter wrote:
> These are few things that Smatch complained about.
> 
> v2:
> I had a wrong goto in patch 3 so there was still a leak.
> Improve the naming.
> 
> Dan Carpenter (3):
>   irqchip/gic-v5: Delete a stray tab
>   irqchip/gic-v5: Fix forever loop in gicv5_its_create_itt_two_level()
>     error handling
>   irqchip/gic-v5: Fix error handling in  gicv5_its_irq_domain_alloc()
> 
>  drivers/irqchip/irq-gic-v5-irs.c |  2 +-
>  drivers/irqchip/irq-gic-v5-its.c | 24 ++++++++++++++++--------
>  2 files changed, 17 insertions(+), 9 deletions(-)

I reviewed and tested these fixes by injecting an error in the ITS
IRQ domain allocation path for a multi-MSI device - code failed and
the retry (that is not there in the code for obvious reasons)
succeeded, so for the series:

Reviewed-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Tested-by: Lorenzo Pieralisi <lpieralisi@kernel.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-18  9:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-17 18:45 [PATCH v2 0/3] irqchip/gic-v5: Fix some static checker issues Dan Carpenter
2025-07-18  9:33 ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).